Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LSP hover popup hard to read #209

Closed
TisnKu opened this issue Sep 27, 2022 · 4 comments
Closed

LSP hover popup hard to read #209

TisnKu opened this issue Sep 27, 2022 · 4 comments

Comments

@TisnKu
Copy link
Contributor

TisnKu commented Sep 27, 2022

Thanks for the great theme! The background color of lsp hover is the same with buffer editor:
image

@ful1e5
Copy link
Member

ful1e5 commented May 5, 2023

@TisnKu During the refactoring process, I resolved the issue but forgot to reference it. To ensure the fix is implemented, please use commit 4d5a4ce on the main branch or a later revision.

@TisnKu
Copy link
Contributor Author

TisnKu commented May 6, 2023

I just tried and it works.
image

But for some theme the hover is still not very obvious. So I enabled hover border as a workaround.
image

@ful1e5 ful1e5 closed this as completed May 6, 2023
@enthusiva
Copy link

Hi. still I could not get the borders shown for the high contrast theme. I use lsp zero nvim package with default recommended preset. I could see the borders for telescope floats but not for lsp floats. Am I missing anything?
image

@tmillr
Copy link
Member

tmillr commented Aug 15, 2023

It's either the highlights, or floating window config (i.e. it might not even be configured to draw a border). I'm not familiar with lsp zero, but by default in neovim, hover and signature popups/floats use the highlight group FloatBorder for their borders. If that plugin is following the defaults, you can do :verb hi FloatBorder to see the highlight definition and visualize what colors are getting used for the border. By using :verb, it should also tell you where that highlight group was last set.

For example:

Screenshot 2023-08-14 at 5 31 54 PM

After running that command, if the fg color is clearly visible in the highlight example (as it is in my screenshot), then you'll need to refer to the config and docs of lsp zero to ensure that these float borders are properly configured. I believe that telescope uses its own custom highlight groups for its float borders, which may or may not link back to FloatBorder.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants