Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BufferLine wrong buffer highlighting #218

Closed
Orlinky opened this issue Dec 3, 2022 · 6 comments
Closed

BufferLine wrong buffer highlighting #218

Orlinky opened this issue Dec 3, 2022 · 6 comments
Assignees
Labels
assigned Under progress.
Projects

Comments

@Orlinky
Copy link

Orlinky commented Dec 3, 2022

Hello,

Recently I updated my neovim plugins after not doing it for about 3 months and to my surprise this broke the unselected buffers highlighting in bufferline.nvim without me changing anything.

Before:
before
After:
after

I looked at the commit history since my last update and this one c306cbd grabbed my attention.

When I remove the line BufferLineBackground = { fg = c.syntax.comment } I always get the initial behaviour regardless if I am only using BufferLineIndicatorSelected = { fg = c.syntax.param } or the original BufferLineIndicatorSelected = { fg = c.blue }

Am I misunderstanding something or was there a mistake with this commit?

My configuration does not have any custom highlighting for bufferline.nvim it always worked out of the box with this colorscheme.
I am using Neovim 0.8.1 with iTerm on macOS.
My terminal's colorscheme is the one from projekt0n/github-theme-contrib.

@jinzhongjia
Copy link

I also meet the problem, and my system is archlinux, neovim version is nightly, and the neovim client neovide

@sjdonado
Copy link

sjdonado commented Dec 8, 2022

Same here! macOS + iTerm2

@fgimian
Copy link

fgimian commented Dec 30, 2022

I can confirm the same issue here on Windows 11 too.

image

ellisonleao added a commit to ellisonleao/neovimfiles that referenced this issue Jan 16, 2023
- add override for bufferline bug. Ref projekt0n/github-nvim-theme#218
@ema2159
Copy link

ema2159 commented Apr 3, 2023

This issue still persists

@ful1e5 ful1e5 self-assigned this May 7, 2023
@ful1e5 ful1e5 added the assigned Under progress. label May 7, 2023
@ful1e5 ful1e5 added this to To do in Workboard via automation May 7, 2023
@ful1e5 ful1e5 moved this from To do to In progress in Workboard May 7, 2023
@ful1e5
Copy link
Member

ful1e5 commented May 8, 2023

During the refactoring process, I resolved the issue but forgot to reference it. To ensure the fix is implemented, please use commit 4d5a4ce on the main branch or a later revision.

@ful1e5
Copy link
Member

ful1e5 commented May 13, 2023

Closing due to inactivity. Can reopen later.

@ful1e5 ful1e5 closed this as completed May 13, 2023
Workboard automation moved this from In progress to Done May 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assigned Under progress.
Projects
Development

No branches or pull requests

6 participants