Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some highlights broken after dc7c6dc0a7fcba693217f907f8cd0a07e4b09448 #223

Closed
ldelossa opened this issue Jan 5, 2023 · 1 comment
Closed

Some highlights broken after dc7c6dc0a7fcba693217f907f8cd0a07e4b09448 #223

ldelossa opened this issue Jan 5, 2023 · 1 comment

Comments

@ldelossa
Copy link

ldelossa commented Jan 5, 2023

After this commit:

HEAD is now at dc7c6dc fix: clear highlights before applying theme

Some theming has broken across plugins.

screenshot-20230104-211731
screenshot-20230104-211659

Example is with Glance.nvim, but my lualine changed as well.
ful1e5 added a commit that referenced this issue Jan 5, 2023
@ful1e5
Revert "fix: clear highlights before applying theme"
602d38a 
This reverts commit dc7c6dc, which may
have caused plugin highlight related issues, as mentioned in #223 and #224.
I've identified that reverting this commit resolves these issues.
@ful1e5
Copy link
Member

ful1e5 commented Jan 8, 2023

Closing according to 602d38a. If you still have issues, please continue the discussion or reopen this issue if needed. Thank you.

@ful1e5 ful1e5 closed this as completed Jan 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ldelossa @ful1e5