Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

border is not required when using dark_sidebar #228

Closed
yamatsum opened this issue Jan 21, 2023 · 6 comments
Closed

border is not required when using dark_sidebar #228

yamatsum opened this issue Jan 21, 2023 · 6 comments
Labels
help wanted Extra attention is needed

Comments

@yamatsum
Copy link
Contributor

There is no line on sidebar border in vscode.
(not strictly noticeable)
CleanShot 2023-01-22 at 00 19 07@2x

border is not required when using dark_sidebar.
CleanShot 2023-01-22 at 00 20 47@2x

@ful1e5
Copy link
Member

ful1e5 commented Jan 22, 2023

In Vim, all split windows are considered to be actual buffers. To change the color of the line between the nvim-tree and the buffer, it is necessary to assign a color to the VertSplit highlight. However, implementing this change will apply to all vertical split window division lines, which can negatively impact readability. Vim users typically prefer to distinguish between their buffers while splitting. On the other hand, VSCode has a separate group for assigning colors to its Explorer (file browsing sidebar).

If this request is feasible through the use of nvim autocmds, I would like to propose it as a feature request during or after a refactoring process. If any alternative solutions or workarounds are available, they would be greatly appreciated.

If you don't mind, could you please share the font used in the screenshot?

@ful1e5 ful1e5 added the help wanted Extra attention is needed label Jan 22, 2023
@yamatsum
Copy link
Contributor Author

How about using NvimTreeVertSplit?

If you don't mind, could you please share the font used in the screenshot?

@ful1e5
Copy link
Member

ful1e5 commented Jan 22, 2023

There is no highlight feature that compares to the NvimtreeVertSplit offered by the nvim-tree plugin. I attempted to override the highlight, but was not successful. If we are able to successfully override this highlight, we may consider other sidebar-related plugins such as litee.nvim and neo-tree, to maintain a consistent aesthetic. I believe it may be possible to achieve this through the use of autocmds, similar to the method used for darkening sidebars.

Thank you for sharing the font.

@yamatsum
Copy link
Contributor Author

yamatsum commented Jan 22, 2023

@ful1e5
I'm sorry, the name of the highlight seems to have changed.
nvim-tree/nvim-tree.lua#1219
It worked well with NvimTreeWinSeparator

@ful1e5
Copy link
Member

ful1e5 commented Jan 24, 2023

The NvimTreeWinSeparator highlight appears to be functioning properly, however, when the side option is changed to 'right', it no longer functions correctly. It appears to be an issue with the plugin.

nvim-tree-winseparator-bug.mp4

@ful1e5
Copy link
Member

ful1e5 commented May 3, 2023

Try a new revision on main after 4d5a4ce.

@ful1e5 ful1e5 closed this as completed May 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants