Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem with configuration options after most recent update (88d4373, on April 6) #238

Closed
telemachus opened this issue Apr 6, 2023 · 3 comments
Assignees

Comments

@telemachus
Copy link

telemachus commented Apr 6, 2023

The latest commit (88d4373) seems to have made it impossible to turn some configuration items off.

Here is my setup code:

require('github-theme').setup({
    comment_style = 'NONE',
    keyword_style = 'NONE',
    function_style = 'NONE',
    variable_style = 'NONE',
    theme_style = 'light',
    sidebars = { 'qf', 'lf' },
    hide_end_of_buffer = false,
    hide_inactive_statusline = false,
    dark_float = true,
    dark_sidebar = true,
    transparent = true,
    overrides = function(c)
        return {
            Conceal = { fg = c.fg },
        }
    end,
})

On the latest commit, comments and keywords are in italics. If I check out the second-to-last commit, everything is fine again (i.e., no italics where I don't want them). I see that you deprecated vim.g.github* configuration, but I don't think that should be my problem since I was already using a Lua setup function.

Other information:

  • neovim v0.9.0-dev-1352+g0bc323850
  • macOS 12.6.4
  • iTerm2 3.4.19

I will try to take a look at the latest commit myself over the weekend. If you need any other information, please let me know.

@idr4n
Copy link

idr4n commented Apr 7, 2023

Strangely my configuration is not picked up when I open Nvim in a normal shell session (color overrides and all...). However if I open Nvim using Tmux, then it is picked up. This happened only after the recent update.

ful1e5 added a commit that referenced this issue Apr 7, 2023
The config module has been rewritten and a new library called `collect`
has been added. This library provides utilities for setting options and
overriding options in the config module.

This also addresses #238 if it's caused by the one-level override of
user config.
@ful1e5 ful1e5 self-assigned this Apr 7, 2023
@ful1e5
Copy link
Member

ful1e5 commented Apr 7, 2023

I have rewritten the config module in commit 0e4887c. If the issue persists, please inform me.

@telemachus
Copy link
Author

telemachus commented Apr 7, 2023

Thanks for the quick fix. Everything seems fine for me now, so I'll close this issue. Thanks for the colorscheme.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants