Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub dark is not dark like the vscode theme #24

Closed
hsheikhali1 opened this issue Jul 12, 2021 · 4 comments
Closed

GitHub dark is not dark like the vscode theme #24

hsheikhali1 opened this issue Jul 12, 2021 · 4 comments
Assignees
Labels
assigned Under progress.
Projects

Comments

@hsheikhali1
Copy link

It could be me but I feel like the vscode theme is darker than this ? The dimmed vscode theme is identical to this one so 👍🏾. Can we get darker "dark" colours ?

@ful1e5
Copy link
Member

ful1e5 commented Jul 13, 2021

There are two variants of dark inside the vscode theme. One is dark (that already supported) and another one is dark default. The dark default is higher contrast one, That follows a different color palette than the primer.

Currently, I'm working on supporting this theme with some plugins and terminals. Once it's get done, I will work on adding the missing part from the vscode-theme. Like tree-sitter queries and some tricky syntax highlights. I'm attaching the issue , Where you will able to track the progress of this project. If you had other issues you are free to share them with me/us.

Check the #16

@yamatsum
Copy link
Contributor

Looking forward to classic dark

@josebalius
Copy link

Also wanted to say im excited to see classic dark. Thank you for working on this ❤️

@ful1e5 ful1e5 added the assigned Under progress. label Aug 21, 2021
@ful1e5 ful1e5 self-assigned this Aug 21, 2021
@Lambdaphile
Copy link

Can't wait for this feature :D So excited

ful1e5 added a commit to ful1e5/github-nvim-theme that referenced this issue Sep 13, 2021
@ful1e5 ful1e5 added this to To do in Workboard via automation Sep 13, 2021
@ful1e5 ful1e5 moved this from To do to In progress in Workboard Sep 13, 2021
@ful1e5 ful1e5 closed this as completed Oct 6, 2021
Workboard automation moved this from In progress to Done Oct 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assigned Under progress.
Projects
Development

No branches or pull requests

5 participants