Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TabLineSel is barely readable #35

Closed
wimstefan opened this issue Jul 16, 2021 · 1 comment · Fixed by #40
Closed

TabLineSel is barely readable #35

wimstefan opened this issue Jul 16, 2021 · 1 comment · Fixed by #40
Labels
assigned Under progress. enhancement New feature or request
Projects

Comments

@wimstefan
Copy link

The readability can be improved tremendously if you assign c.pmenu.select instead of c.fg ...

diff --git a/lua/github-theme/theme.lua b/lua/github-theme/theme.lua
index f3f12c2..74c0a9f 100644
--- a/lua/github-theme/theme.lua
+++ b/lua/github-theme/theme.lua
@@ -68,7 +68,7 @@ function M.setup(config)
     StatusLineNC = {fg = c.fg, bg = c.bg}, -- status lines of not-current windows Note: if this is equal to "StatusLine" Vim will use "^^^" in the status line of the current window.
     TabLine = {bg = c.bg, fg = c.fg}, -- tab pages line, not active tab page label
     TabLineFill = {bg = c.bg2}, -- tab pages line, where there are no labels
-    TabLineSel = {fg = c.fg, bg = c.blue}, -- tab pages line, active tab page label
+    TabLineSel = {fg = c.pmenu.select, bg = c.blue}, -- tab pages line, active tab page label
     Title = {fg = c.syntax.variable, style = "bold"}, -- titles for output from ":set all", ":autocmd" etc.
     Visual = {bg = c.bg_visual_selection}, -- Visual mode selection
     VisualNOS = {bg = c.bg_visual_selection}, -- Visual mode selection when vim is "Not Owning the Selection".
@ful1e5 ful1e5 added assigned Under progress. enhancement New feature or request labels Jul 16, 2021
@ful1e5 ful1e5 added this to To do in Workboard via automation Jul 16, 2021
@ful1e5 ful1e5 moved this from To do to In progress in Workboard Jul 16, 2021
ful1e5 added a commit to ful1e5/github-nvim-theme that referenced this issue Jul 17, 2021
Workboard automation moved this from In progress to Done Jul 17, 2021
@wimstefan
Copy link
Author

Thank you so much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assigned Under progress. enhancement New feature or request
Projects
Development

Successfully merging a pull request may close this issue.

2 participants