Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lualine light theme doesn't work anymore #60

Closed
flipflop133 opened this issue Aug 20, 2021 · 4 comments
Closed

Lualine light theme doesn't work anymore #60

flipflop133 opened this issue Aug 20, 2021 · 4 comments
Assignees
Labels
assigned Under progress. bug Something isn't working
Projects

Comments

@flipflop133
Copy link

The lualine bar currently looks like this using light mode:
image
My config:

        -- Status line
	use {
		'hoob3rt/lualine.nvim',
		config = function()
			require'lualine'.setup{options={theme = 'github'}}
		end
	}
        -- Theme
	use {
		'projekt0n/github-nvim-theme',
		config = function()
			require('github-theme').setup({
				themeStyle = "light",
			})
		end
	}
@ful1e5
Copy link
Member

ful1e5 commented Aug 21, 2021

  -- Status Line
  use {
    "hoob3rt/lualine.nvim",
    config = function()
      require("lualine").setup {options = {theme = "github"}}
    end
  }

  -- Theme
  use {
    "projekt0n/github-nvim-theme",
    requires = {{"hoob3rt/lualine.nvim", opt = true}},
    config = function()
      require("github-theme").setup({themeStyle = "light"})
    end
  }

Then run :PackerSync

@flipflop133
Copy link
Author

This doesn't fix the issue unfortunately.

@ful1e5 ful1e5 added assigned Under progress. bug Something isn't working labels Aug 28, 2021
@ful1e5 ful1e5 self-assigned this Aug 28, 2021
@ful1e5 ful1e5 added this to To do in Workboard via automation Aug 28, 2021
@ful1e5 ful1e5 moved this from To do to In progress in Workboard Aug 28, 2021
@ful1e5
Copy link
Member

ful1e5 commented Aug 29, 2021

For a light theme, you have to set your background value to light.
By setting vim.o.background to "light", lualine inheritance proper colors from github-theme.

using packer

use {
  "hoob3rt/lualine.nvim",
  config = function()
    require("lualine").setup {options = {theme = "github"}}
  end
}

-- Theme
use {
  "projekt0n/github-nvim-theme",
  requires = {{"hoob3rt/lualine.nvim", opt = true}},
  config = function()
    vim.o.background = "light"
    require("github-theme").setup({themeStyle = "light"})
  end
}

@flipflop133
Copy link
Author

thanks that works!

Workboard automation moved this from In progress to Done Aug 29, 2021
ful1e5 added a commit to ful1e5/github-nvim-theme that referenced this issue Oct 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assigned Under progress. bug Something isn't working
Projects
Development

No branches or pull requests

2 participants