transparent + hideEndOfBuffer still shows EndOfBuffer symbols

[jakobkhansen]

When both transparent and hideEndOfBuffer is true, EndOfBuffer symbols (~) still seems to show, this seems like a bug.

[ful1e5]

There is no such thing as hidden EndOfBuffer in nvim. This colorscheme basically set EndOfBuffer color with the background color. Means it's still there but we can't see.

I removed a bit of code for setting the EndOfBuffer color. Now, It still appears but it is now less interrupting. You can also override the value of the colors with eob & sidebar_eob :

require("github-theme").setup({
  colors = {sidebar_eob = "", eob = ""}
  -- other config
})