Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New terminal foreground color is TOO black #76

Closed
Complex2-Liu opened this issue Sep 18, 2021 · 0 comments
Closed

New terminal foreground color is TOO black #76

Complex2-Liu opened this issue Sep 18, 2021 · 0 comments
Assignees
@ful1e5
Labels
assigned Under progress. bug Something isn't working
Projects
Workboard

Comments

@Complex2-Liu
Copy link

Upon this commit.

The original foreground color is good, having sufficient contrast between text color and its background.
The new one is terrible, I bet 0x424242 is a typo?
@ful1e5 ful1e5 self-assigned this Sep 21, 2021
@ful1e5 ful1e5 added assigned Under progress. bug Something isn't working labels Sep 21, 2021
@ful1e5 ful1e5 added this to To do in Workboard via automation Sep 21, 2021
@ful1e5 ful1e5 closed this as completed in ff029d6 Sep 21, 2021
ful1e5 added a commit that referenced this issue Sep 21, 2021
@ful1e5
Merge pull request #82 from ful1e5/main
4bc66fa 
fix: #76
Workboard automation moved this from To do to Done Sep 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ful1e5 ful1e5

Labels
assigned Under progress. bug Something isn't working
Projects
Workboard
Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ful1e5 @Complex2-Liu