-
-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
💄 Add iterm themes #14
Conversation
This adds three iterm themes, generated by converting the existing kitty ones manually to xresources format and converting them to iterm2 via terminal.sexy. The same thing can be easily done for other terminals, if needed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we do with Lua templating. That reduces pain afterward when we change colors inside colors.lua
.
Reference extra lua module
I considered that, but I'm not that proficient with lua and preferred to provide a quick solution for people wanting iterm themes. |
Ok, I've taken a dive into your code. The main problem is that while kitty and alacritty write colors as hex codes (
Your code would need to be changed a lot to accomodate this: your Do you have any hint about how to do this? Or any better solution? Thanks and keep up the great work! |
Try this util function for converting hex to RGB. You can also adjust the floating-point with the local hex2rgb = function(hex)
local _, redColor, greenColor, blueColor = hex:match("(.)(..)(..)(..)")
redColor, greenColor, blueColor =
string.format("%0.16f", (tonumber(redColor, 16) / 255)),
string.format("%0.16f", (tonumber(greenColor, 16) / 255)),
string.format("%0.16f", (tonumber(blueColor, 16) / 255))
return redColor, greenColor, blueColor
end References |
Hey @ful1e5! I already managed to write a utility function to convert the individual colors. I still have to figure out a solution to properly pass them to the template, as adapting your |
@metalelf0 Can you able share variable names according to |
I'm able to generate an itermcolors scheme with this bit of code. The only problem it has is colors.
|
Mmm, with this code I get this error when running |
try with new window of nvim with |
Ok, running it with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing
This adds three iterm themes, generated by converting the existing kitty ones manually to xresources format and converting them to iterm2 via terminal.sexy. The same thing can be easily done for other terminals, if needed.