Add AutoAliasing code migration #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iwahbe
reviewed
Apr 14, 2023
upgrade/migrations_test.go
Outdated
| ` | ||
|
|
||
| // Write original program to temporary file | ||
| orig, err := os.Create("original.go") |
There was a problem hiding this comment.
If we need to write to a temp file, at least put it in temporary directory. Ideally, we would be able to do the test in memory though.
| "github.com/stretchr/testify/assert" | ||
| ) | ||
|
|
||
| func TestAutoAliasingMigration(t *testing.T) { |
There was a problem hiding this comment.
Let's make sure we can run AutoAliasing multiple times on a file without changes. We should write migrations with the expectation that they will be run on every provider every time.
There was a problem hiding this comment.
It looks like that is handled by another part of the migration. Can we get a test for that part as well?
Closed
t0yv0
reviewed
Apr 17, 2023
iwahbe
approved these changes
Apr 17, 2023
| @@ -197,6 +216,30 @@ func UpgradeProvider(ctx Context, name string) error { | |||
| In(repo.providerDir())) | |||
| } | |||
|
|
|||
| if ctx.UpgradeCodeMigration { | |||
| applied := make(map[string]struct{}) | |||
| for _, opt := range ctx.MigrationOpts { | |||
There was a problem hiding this comment.
We should make sure this is sorted so we get the same output however the user specifies the migrations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an option to perform code migrations on providers, either alongside a normal provider updates (by default or if --kind=all), or by itself (if --kind=code).
If --kind=all, all available code migrations options will be performed.
If --kind=code, a list of options must be specified via --migration-opts.
Currently the only option is to add AutoAliasing.