added an option to enable GCP healthcheck endpoints #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Have you considered using |
|
@ploxiln Hmm. Interesting idea. I think it's not quite the right approach, though, because if the upstream app were to get sad, GCP would begin killing and restarting the proxy, even if it were actually operating perfectly. I'd rather the proxy remain up and happy, waiting for the upstream to return. |
3 tasks
|
Looks good to me. Thank you for incorporating those changes! Good stuff |
JoelSpeed
reviewed
Mar 26, 2019
JoelSpeed
approved these changes
Mar 27, 2019
There was a problem hiding this comment.
Great, Thanks for your work on this @timothy-spencer (and @benfdking for #93), I'll get this merged!
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds an option that lets you enable GCP healthcheck endpoints.
https://cloud.google.com/appengine/docs/flexible/custom-runtimes/configuring-your-app-with-app-yaml#updated_health_checks
It also incorporates suggestions from #93 that lets it work with GKE ingresses.
Motivation and Context
GCP likes to know when the app is up and running. Enabling these endpoints makes it so that it is easy to run the proxy in the GCP App Engine environment
How Has This Been Tested?
I use the go test ./... tests, as well as tested this by hand by launching with and without the flag enabled and attempting to go to locahost:4180/liveness_check and localhost:4180/readiness_check. With the flag enabled, I got back "OK", and without, I got the normal auth redirect.
Checklist: