Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose -cookie-path as configuration parameter #122

Merged
merged 4 commits into from Apr 10, 2019
Merged

Expose -cookie-path as configuration parameter #122

merged 4 commits into from Apr 10, 2019

Conversation

costelmoraru
Copy link
Contributor

Description

Exposes the Path attribute of the cookie as config parameter -cookie-path to allow be more flexible cookie configuration.

Motivation and Context

This is the PR for the issue #121

How Has This Been Tested?

Unit tests are passing.
Tested in our environments.

Checklist:

  • My change requires a change to the documentation or CHANGELOG.
  • I have updated the documentation/CHANGELOG accordingly.
  • I have created a feature (non-master) branch for my PR.

@costelmoraru costelmoraru requested a review from a team April 9, 2019 21:40
JoelSpeed
JoelSpeed previously approved these changes Apr 10, 2019
Copy link
Member

@JoelSpeed JoelSpeed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a sensible improvement. Thanks 😄

@JoelSpeed
Copy link
Member

Just one little thing before this gets merged, could you update the documentation to add this flag to the list of flags?

@costelmoraru
Copy link
Contributor Author

Good catch, thank you for that.
I've just pushed the updated documentation.

README.md Outdated Show resolved Hide resolved
Copy link
Member

@JoelSpeed JoelSpeed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants