Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: use go 1.12 #124

Merged
merged 2 commits into from Apr 12, 2019
Merged

build: use go 1.12 #124

merged 2 commits into from Apr 12, 2019

Conversation

loshz
Copy link
Member

@loshz loshz commented Apr 12, 2019 •
edited

Description

  • Upgraded Go version for Docker and Travis builds to 1.12
  • Removed Go version 1.10 from Travis CI environment.

Motivation and Context

  • Go 1.12 is the current minor release therefore this upgrade is recommended.

How Has This Been Tested?

  • Successfully built locally.
  • Successfully built on Travis CI environment.

Checklist:

  • My change requires a change to the documentation or CHANGELOG.
  • I have updated the documentation/CHANGELOG accordingly.
  • I have created a feature (non-master) branch for my PR.

@loshz loshz requested review from JoelSpeed and a team April 12, 2019 09:40
@loshz loshz mentioned this pull request Apr 12, 2019
Merged
3 tasks
@JoelSpeed
Copy link
Member

Should we add a Changelog for this?

@loshz
Copy link
Member Author

loshz commented Apr 12, 2019

I was going to add it to #123 - or is that not the correct method?

@JoelSpeed
Copy link
Member

Can do either but I've been tending to get people to add their own changelog in each PR so that we don't miss any

@loshz
Copy link
Member Author

loshz commented Apr 12, 2019

PTAL

JoelSpeed
JoelSpeed approved these changes Apr 12, 2019
View reviewed changes
Copy link
Member

@JoelSpeed JoelSpeed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@loshz loshz merged commit bf9fedb into oauth2-proxy:master Apr 12, 2019
@loshz loshz deleted the go-1.12 branch April 12, 2019 10:15
@karlskewes karlskewes mentioned this pull request May 3, 2019
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoelSpeed JoelSpeed JoelSpeed approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@loshz @JoelSpeed