Docker improvement #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ploxiln
reviewed
Jan 20, 2019
JoelSpeed
requested changes
Jan 20, 2019
JoelSpeed
reviewed
Jan 21, 2019
yaegashi
force-pushed
the
docker-improvement
branch
2 times, most recently
from
16606ec
to
ebf7b2c
Compare
|
@yaegashi I've just checked over this and am happy with the content now, would you please squash the changes into logical commits and we'll get this merged |
yaegashi
force-pushed
the
docker-improvement
branch
3 times, most recently
from
156d4dd
to
01461f8
Compare
Update Makefile to build a static binary by default.
Update Dockefile to get a much smaller footprint with alpine image. Optimize ordering of build steps to avoid needless downloads. Include CA certificates needed for practical use.
Dockerfile.dev is ignored by both git and docker for faster development cycle of docker build.
yaegashi
force-pushed
the
docker-improvement
branch
from
01461f8
to
ccaa6e9
Compare
|
@JoelSpeed Squashed the changes into 3 commits. Feel free to ammend the commit logs or other wording issues before merging them. |
JoelSpeed
approved these changes
Jan 21, 2019
3 tasks
michael-freidgeim-webjet
added a commit
to MNF/oauth2-proxy
that referenced
this pull request
Sep 4, 2021
Added audit log to indicate login username
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update Makefile and Dockerfile to build a static binary and get a much smaller footprint with alpine image. It also includes CA certificates needed for practical use.
Add Dockerfile.dev in .gitignore and .dockerignore. It's to utilize cached build steps on Dockerfile development.
Optimize ordering of build steps in Dockerfile to avoid needless downloads.
Motivation and Context
This PR improves Docker building facilities to achieve a faster development cycle and a smaller footprint image for practical use.
How Has This Been Tested?
You can get build results very fast by utilizing cached build steps on development using Dockerfile.dev.
You can get 17.1MB in size by building this image.
Checklist: