Fall back to using OIDC Subject instead of Email #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoelSpeed
reviewed
Feb 18, 2019
Not super sure about that. This will make this work on systems where it never worked before, but in a peculiar way. Once it is fully fixed correctly (as in email is requested separately from userinfo it is not present in the immediate reply) then the responses will change for these systems, but then also those systems will start working exactly the same as the systems that already work now. |
Email is not mandatory field, Subject is mandatory and expected to be unique. Might want to take a look at UserInfo first, however. Issue: oauth2-proxy#56
Changelog added |
JoelSpeed
approved these changes
Mar 8, 2019
brianv0
added a commit
to lsst-dm/legacy-oauth2_proxy
that referenced
this pull request
May 1, 2019
brianv0
added a commit
to lsst-dm/legacy-oauth2_proxy
that referenced
this pull request
May 1, 2019
brianv0
added a commit
to lsst-dm/legacy-oauth2_proxy
that referenced
this pull request
May 20, 2019
brianv0
added a commit
to lsst-dm/legacy-oauth2_proxy
that referenced
this pull request
May 20, 2019
brianv0
added a commit
to lsst-dm/legacy-oauth2_proxy
that referenced
this pull request
Jun 5, 2019
brianv0
added a commit
to lsst-dm/legacy-oauth2_proxy
that referenced
this pull request
Jun 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Email is not mandatory field, Subject is mandatory and expected to be unique. Might want to take a look at UserInfo first, however.
Issue: #56