Fixes deletion of splitted cookies - Issue #69 #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your comments. I'll change the code and update the PR. |
JoelSpeed
reviewed
Feb 26, 2019
|
Hey, can I do anything to get this merged? |
JoelSpeed
reviewed
Mar 13, 2019
|
I'm done |
|
Hi @einfachchr, there's something kinda weird going on here, the diff now is pulling in loads of additional stuff and there's a mass of new commits from other PRs, any idea what happened? Could you rebase on top of our master branch picking only your commits and then force push again please? I think this should fix it |
|
@JoelSpeed I did a rebase of master. Maybe a bad idea? |
Co-Authored-By: einfachchr <einfachchr@gmail.com>
einfachchr
force-pushed
the
fix_splitted_cookies
branch
from
57c04db
to
eb2514c
Compare
|
@JoelSpeed I did a rebase and force push. Now it looks fine ;-) |
JoelSpeed
approved these changes
Mar 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull requests changes how the cookies are deleted on logout. It changes how the cookie names are
determined.
If you have any questions / suggestions, I'd be glad to add these.
Description
For problem description see Issue #69.
ClearSessionCookie() is changed to search the request cookies for cookies set by this proxy (identified by
name prefix). For each of these a "reset cookie" is generated and set into the response header.
The change only affects the way the cookie names are determined.
Motivation and Context
Fixes Issue #69. A user cannot be logged out in case of splitted cookies.
How Has This Been Tested?
This is tested by unit tests (oauthproxy_test.go - TestClearSplittedCookie, TestClearNotSplittedCookie)
and this is running in our production environment.
Checklist: