Add id_token refresh to Google provider #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoelSpeed
previously approved these changes
Mar 4, 2019
|
Thank you for your review. I have updated the changelog. |
JoelSpeed
approved these changes
Mar 5, 2019
aigarius
pushed a commit
to aigarius/oauth2_proxy
that referenced
this pull request
Mar 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Token refresh does not update id_token in session when using Google provider.
Description
Token refresh does not update id_token in session, so JWT token passed to the backend application is expired while the access_token is updated.
Motivation and Context
Add id_token refresh to Google provider because the JWT token provided by set-authorization-header is outdated after a token refresh.
How Has This Been Tested?
It is tested manually requesting the bearer token from the backend application.