Merge websocket proxy feature from openshift/oauth-proxy #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've had a first pass over this and it looks fantastic! Thanks very much! Looks like there's a problem with the pinned dependencies at the moment though, a |
butzist
force-pushed
the
feature/wsproxy
branch
from
a8e30db
to
5ef0a19
Compare
…thor: Hiram Chirino <hiram@hiramchirino.com>
butzist
force-pushed
the
feature/wsproxy
branch
from
5ef0a19
to
c7193b4
Compare
|
@JoelSpeed Updated dependencies, and build/checks are passing now. |
JoelSpeed
approved these changes
Mar 11, 2019
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Merged websocket proxy support from the openshift fork of oauth-proxy
Motivation and Context
Current oauth-proxy will not work with APIs which upgrade the connection to websocket.
How Has This Been Tested?
Merged unit test from upstream -> passing
Checklist: