-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revamp good practices #10206
Merged
Merged
Revamp good practices #10206
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
0579f60
Remove __init__.py from test directories in fixtures how-to
flying-sheep b3c1377
Merge branch 'main' into patch-1
flying-sheep 6c60840
First attempt to overhaul goodpractices.rst
flying-sheep 5eefd80
no setup.cfg
flying-sheep d65f238
Apply suggestions from code review
flying-sheep 5f7056d
Remove remaining setup.cfgs
flying-sheep 2d67a63
Merge branch 'main' into patch-1
flying-sheep a4c4e06
making footnote a section
flying-sheep File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I personally prefer that we use
setuptools
in our examples, because it is more traditional; using alternatives might give the impression that pytest recommends/only works with hatchling, or support requests on how to do the same with poetry, etc.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmm, maybe we can also use tabs like in the packaging tutorial?
I don’t recommend setuptools as it’s:
but of course I can leave it if you prefer. I’d still get rid of
setup.cfg
since setuptools these days supports PEP 621. Unfortunately configuring it with more than just basic metadata is labelled as “beta”, e.g. this:There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ahh thanks for pointing that out, didn't know that has changed. If the packaging tutorial recommends
hatchling
as first choice, I think we should follow suit then.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In case you would like some context, I followed that discussion, and the reasoning went something like that:
hatch-vcs
)Hatchling doesn’t have a sufficient amount of plugins or example code yet to allow a highly custom build like numpy or numba or so, but for anything with purely static build configuration, it’s a very good choice.