From dc34bdb68f37b298818bc24ab345ea02e3cb47b9 Mon Sep 17 00:00:00 2001
From: levente kiraly <leventekk@users.noreply.github.com>
Date: Fri, 21 Apr 2023 15:34:39 +0200
Subject: [PATCH] fix: refactor defaultProps to disable warning from react
 (#518)

Co-authored-by: Daniel Tschinder <231804+danez@users.noreply.github.com>
---
 src/components/Tab.js              |  9 ++++++---
 src/components/TabList.js          |  7 +++++--
 src/components/TabPanel.js         |  7 +++++--
 src/components/Tabs.js             | 20 ++++++++++++++------
 src/components/UncontrolledTabs.js |  8 ++++++--
 5 files changed, 36 insertions(+), 15 deletions(-)

diff --git a/src/components/Tab.js b/src/components/Tab.js
index f120b891a..b9d023e01 100644
--- a/src/components/Tab.js
+++ b/src/components/Tab.js
@@ -47,7 +47,10 @@ const Tab = (props) => {
     tabIndex,
     tabRef,
     ...attributes
-  } = props;
+  } = {
+    ...defaultProps,
+    ...props,
+  };
 
   useEffect(() => {
     if (selected && focus) {
@@ -78,8 +81,8 @@ const Tab = (props) => {
     </li>
   );
 };
-Tab.propTypes = propTypes;
 
+Tab.propTypes = propTypes;
 Tab.tabsRole = 'Tab';
-Tab.defaultProps = defaultProps;
+
 export default Tab;
diff --git a/src/components/TabList.js b/src/components/TabList.js
index 425bc8317..f4686434c 100644
--- a/src/components/TabList.js
+++ b/src/components/TabList.js
@@ -14,7 +14,10 @@ const propTypes = {
   ]),
 };
 const TabList = (props) => {
-  const { children, className, ...attributes } = props;
+  const { children, className, ...attributes } = {
+    ...defaultProps,
+    ...props,
+  };
 
   return (
     <ul {...attributes} className={cx(className)} role="tablist">
@@ -25,5 +28,5 @@ const TabList = (props) => {
 
 TabList.tabsRole = 'TabList';
 TabList.propTypes = propTypes;
-TabList.defaultProps = defaultProps;
+
 export default TabList;
diff --git a/src/components/TabPanel.js b/src/components/TabPanel.js
index db6e49cff..fadaa4f2d 100644
--- a/src/components/TabPanel.js
+++ b/src/components/TabPanel.js
@@ -29,7 +29,10 @@ const TabPanel = (props) => {
     selected,
     selectedClassName,
     ...attributes
-  } = props;
+  } = {
+    ...defaultProps,
+    ...props,
+  };
 
   return (
     <div
@@ -48,5 +51,5 @@ const TabPanel = (props) => {
 
 TabPanel.tabsRole = 'TabPanel';
 TabPanel.propTypes = propTypes;
-TabPanel.defaultProps = defaultProps;
+
 export default TabPanel;
diff --git a/src/components/Tabs.js b/src/components/Tabs.js
index df731d2cb..44bc44c0e 100644
--- a/src/components/Tabs.js
+++ b/src/components/Tabs.js
@@ -68,11 +68,20 @@ For more information about controlled and uncontrolled mode of react-tabs see ht
  *          It is initialized from the prop defaultFocus, and after the first render it is reset back to false. Later it can become true again when using keys to navigate the tabs.
  */
 const Tabs = (props) => {
-  const { children, defaultFocus, defaultIndex, focusTabOnClick, onSelect } =
-    props;
+  const {
+    children,
+    defaultFocus,
+    defaultIndex,
+    focusTabOnClick,
+    onSelect,
+    ...attributes
+  } = {
+    ...defaultProps,
+    ...props,
+  };
 
   const [focus, setFocus] = useState(defaultFocus);
-  const [mode] = useState(getModeFromProps(props));
+  const [mode] = useState(getModeFromProps(attributes));
   const [selectedIndex, setSelectedIndex] = useState(
     mode === MODE_UNCONTROLLED ? defaultIndex || 0 : null,
   );
@@ -93,7 +102,7 @@ const Tabs = (props) => {
     }, [tabsCount]);
   }
 
-  checkForIllegalModeChange(props, mode);
+  checkForIllegalModeChange(attributes, mode);
 
   const handleSelected = (index, last, event) => {
     // Call change event handler
@@ -113,7 +122,7 @@ const Tabs = (props) => {
     }
   };
 
-  let subProps = { ...props };
+  let subProps = { ...props, ...attributes };
 
   subProps.focus = focus;
   subProps.onSelect = handleSelected;
@@ -128,7 +137,6 @@ const Tabs = (props) => {
 };
 
 Tabs.propTypes = propTypes;
-Tabs.defaultProps = defaultProps;
 Tabs.tabsRole = 'Tabs';
 
 export default Tabs;
diff --git a/src/components/UncontrolledTabs.js b/src/components/UncontrolledTabs.js
index 525230f86..0044dc33a 100644
--- a/src/components/UncontrolledTabs.js
+++ b/src/components/UncontrolledTabs.js
@@ -383,7 +383,10 @@ const UncontrolledTabs = (props) => {
     disableUpDownKeys, // unused
     disableLeftRightKeys, // unused
     ...attributes
-  } = props;
+  } = {
+    ...defaultProps,
+    ...props,
+  };
   return (
     <div
       {...attributes}
@@ -400,6 +403,7 @@ const UncontrolledTabs = (props) => {
     </div>
   );
 };
-UncontrolledTabs.defaultProps = defaultProps;
+
 UncontrolledTabs.propTypes = propTypes;
+
 export default UncontrolledTabs;