feature/ignore-interface-in-privatize-constants-command #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| $excludedPaths, | ||
| static fn (SplFileInfo $splFileInfo): bool => ! str_ends_with( | ||
| $splFileInfo->getFilenameWithoutExtension(), | ||
| 'Interface' |
There was a problem hiding this comment.
What about interface that do not have such suffix?
There was a problem hiding this comment.
This interface should be skipped too, but the there is no "Interface" suffix:
interface NotSuffixed
{
}There was a problem hiding this comment.
Parse file content for this check will be ok?
There was a problem hiding this comment.
Indeed, that's the way.
Somewhere here maybe:
There was a problem hiding this comment.
I have done it another way. It does not cover all edge cases, but it should work for 99% of cases.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.