-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rewrite empty_line_after_doc_comments
and empty_line_after_outer_attr
, move them from nursery
to suspicious
#13091
Conversation
7ea9443
to
e5191b0
Compare
☔ The latest upstream changes (presumably #13088) made this pull request unmergeable. Please resolve the merge conflicts. |
e5191b0
to
b65e900
Compare
Sorry for the wait, I'll review it in the weekend |
No rush here, whenever you get around to it is fine |
b65e900
to
2e02805
Compare
No changes in that rebase, just wanted to try out #13124 |
☔ The latest upstream changes (presumably #13180) made this pull request unmergeable. Please resolve the merge conflicts. |
2e02805
to
f660e29
Compare
☔ The latest upstream changes (presumably #13261) made this pull request unmergeable. Please resolve the merge conflicts. |
f660e29
to
2c6d800
Compare
☔ The latest upstream changes (presumably #13278) made this pull request unmergeable. Please resolve the merge conflicts. |
2c6d800
to
02b4b81
Compare
☔ The latest upstream changes (presumably #13244) made this pull request unmergeable. Please resolve the merge conflicts. |
02b4b81
to
d1193e7
Compare
☔ The latest upstream changes (presumably #12993) made this pull request unmergeable. Please resolve the merge conflicts. |
d1193e7
to
3474df6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great stuff! Thanks for this!
@bors r+ |
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
changelog: [
empty_line_after_doc_comments
], [empty_line_after_outer_attr
]: rewrite and move them fromnursery
tosuspicious
They now lint when there's a comment between the last attr/doc comment and the empty line, to cover the case:
When these lints or
suspicious_doc_comments
trigger we no longer trigger any other doc lint as a broad fix for #12917, reverts some of #13002 as the empty line lints cover itI ended up not doing #12917 (comment) as I don't think it's needed