Rewrite empty_line_after_doc_comments and empty_line_after_outer_attr, move them from nursery to suspicious

[Alexendoo]

changelog: [empty_line_after_doc_comments], [empty_line_after_outer_attr]: rewrite and move them from nursery to suspicious

They now lint when there's a comment between the last attr/doc comment and the empty line, to cover the case:

/// Docs for `old_code
// fn old_code() {}

fn new_code() {}

When these lints or suspicious_doc_comments trigger we no longer trigger any other doc lint as a broad fix for #12917, reverts some of #13002 as the empty line lints cover it

I ended up not doing #12917 (comment) as I don't think it's needed

[rustbot]

r? @dswij

rustbot has assigned @dswij.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

[bors]

☔ The latest upstream changes (presumably #13088) made this pull request unmergeable. Please resolve the merge conflicts.

[dswij]

Sorry for the wait, I'll review it in the weekend

[Alexendoo]

No rush here, whenever you get around to it is fine

[Alexendoo]

No changes in that rebase, just wanted to try out #13124

[bors]

☔ The latest upstream changes (presumably #13180) made this pull request unmergeable. Please resolve the merge conflicts.

[bors]

☔ The latest upstream changes (presumably #13261) made this pull request unmergeable. Please resolve the merge conflicts.

[bors]

☔ The latest upstream changes (presumably #13278) made this pull request unmergeable. Please resolve the merge conflicts.

[bors]

☔ The latest upstream changes (presumably #13244) made this pull request unmergeable. Please resolve the merge conflicts.

[bors]

☔ The latest upstream changes (presumably #12993) made this pull request unmergeable. Please resolve the merge conflicts.

[dswij]

This is great stuff! Thanks for this!

[dswij]

@bors r+

[bors]

📌 Commit 3474df6 has been approved by dswij

It is now in the queue for this repository.

[bors]

⌛ Testing commit 3474df6 with merge ebcd6bc...

[bors]

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: dswij
Pushing ebcd6bc to master...