-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix redundant_closure
false positive with closures has return type contains 'static
#13108
Conversation
6062dbb
to
84182ff
Compare
6fc6518
to
33d00b3
Compare
☔ The latest upstream changes (presumably #13157) made this pull request unmergeable. Please resolve the merge conflicts. |
Also get the receiver T in `T.method(|| f())`.
33d00b3
to
0bc9f00
Compare
Sorry for the long wait here, I don't have enough time to properly look into/review this atm, so I'm going to reroll to not block this any longer: r? clippy |
Looks good to me, thank you for the fix and slight refactoring :D Roses are red, |
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
Fix #13073 .
Please enable "ignore white-space change" settings in github UI for easy reviewing.
HACK: The third commit contains a hack to check if a type
T: 'static
whenfn() -> U where U: 'static
.I don't have a clean way to check for it.
changelog: [
redundant_closure
] Fix false positive with closures has return type contains'static