Fix mut_mutex_lock
when reference not ultimately mutable
#13122
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When there is are multiple references where one of the references isn't mutable then this results in a false-positive for
mut_mutex_lock
as it only checks the mutability of the first reference level.Fix this by using
peel_mid_ty_refs_is_mutable
which correctly determines whether the reference is ultimately mutable and thus whetherMutex::get_lock()
can actually be used.Fixes #9854
changelog: [
mut_mutex_lock
]: No longer lints if the mutex is behind multiple references and one of those references isn't mutable