From 9e577f5ed982736747b0a0c60dd1234b92dc3351 Mon Sep 17 00:00:00 2001 From: Thomas B <9094255+Ten0@users.noreply.github.com> Date: Sun, 14 Jul 2024 15:02:54 +0200 Subject: [PATCH] fix(blocking): Fix `.header()` unsetting `sensitive` on `HeaderValue` (#2353) Fixes #2352 --- src/blocking/request.rs | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/blocking/request.rs b/src/blocking/request.rs index 9acc1e16a..8ac112444 100644 --- a/src/blocking/request.rs +++ b/src/blocking/request.rs @@ -211,7 +211,12 @@ impl RequestBuilder { match >::try_from(key) { Ok(key) => match >::try_from(value) { Ok(mut value) => { - value.set_sensitive(sensitive); + // We want to potentially make an unsensitive header + // to be sensitive, not the reverse. So, don't turn off + // a previously sensitive header. + if sensitive { + value.set_sensitive(true); + } req.headers_mut().append(key, value); } Err(e) => error = Some(crate::error::builder(e.into())),