feat: improve types with generic extend #2353
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
This changes the way types work in Got by making got a generic function of the passed in options.
Fixes #1117 and opens up to some new generic patterns that may make the TS experience better. It doesn't look like there are any specific tests for types, but this was light enough change that it didn't take any code changes.
There shouldn't be really any "breaking" changed here, the types work a little different, but that shouldn't be noticeable to most I don't think.