From 5ce7a2b7c5c8e36d045f155fdf5fba05e9c575d5 Mon Sep 17 00:00:00 2001 From: Justin Searls Date: Sun, 23 Jun 2024 11:27:58 -0400 Subject: [PATCH] backport https://github.com/standardrb/standard/commit/de139d7385c36d195b2b1fbadd5c112764f60b8b --- lib/ruby_lsp/standard/wraps_built_in_lsp_standardizer.rb | 2 +- test/ruby_lsp_addon_test.rb | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/ruby_lsp/standard/wraps_built_in_lsp_standardizer.rb b/lib/ruby_lsp/standard/wraps_built_in_lsp_standardizer.rb index 23794042..60012a2a 100644 --- a/lib/ruby_lsp/standard/wraps_built_in_lsp_standardizer.rb +++ b/lib/ruby_lsp/standard/wraps_built_in_lsp_standardizer.rb @@ -51,7 +51,7 @@ def run_diagnostic(uri, document) severity: severity, range: RubyLsp::Interface::Range.new( start: RubyLsp::Interface::Position.new(line: loc[:start_line] - 1, character: loc[:start_column] - 1), - end: RubyLsp::Interface::Position.new(line: loc[:last_line] - 1, character: loc[:last_column] - 1) + end: RubyLsp::Interface::Position.new(line: loc[:last_line] - 1, character: loc[:last_column]) ) # TODO: We need to do something like to support quickfixes thru code actions # See: https://github.com/Shopify/ruby-lsp/blob/4c1906172add4d5c39c35d3396aa29c768bfb898/lib/ruby_lsp/requests/support/rubocop_diagnostic.rb#L62 diff --git a/test/ruby_lsp_addon_test.rb b/test/ruby_lsp_addon_test.rb index edf45943..8c1f12d3 100644 --- a/test/ruby_lsp_addon_test.rb +++ b/test/ruby_lsp_addon_test.rb @@ -51,7 +51,7 @@ def test_diagnostic assert_equal 1, result.response.items.size item = result.response.items.first assert_equal({line: 0, character: 4}, item.range.start.to_hash) - assert_equal({line: 0, character: 10}, item.range.end.to_hash) + assert_equal({line: 0, character: 11}, item.range.end.to_hash) assert_equal RubyLsp::Constant::DiagnosticSeverity::INFORMATION, item.severity assert_equal "Style/StringLiterals", item.code assert_equal "https://docs.rubocop.org/rubocop/cops_style.html#stylestringliterals", item.code_description.href