{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":283556259,"defaultBranch":"main","name":"kyber-k2so","ownerLogin":"symbolicsoft","currentUserCanPush":false,"isFork":false,"isEmpty":false,"createdAt":"2020-07-29T17:03:38.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/26714438?v=4","public":true,"private":false,"isOrgOwned":true},"refInfo":{"name":"","listCacheKey":"v0:1703933899.0","currentOid":""},"activityList":{"items":[{"before":"8fb6dc4f5ee9e7c8abf43faf366fcae1792139d9","after":"f97c7356b2eeca1d3672effe2aca05acd4c4d473","ref":"refs/heads/main","pushedAt":"2024-01-01T09:31:49.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"nadimkobeissi","name":"Nadim Kobeissi","path":"/nadimkobeissi","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/9953?s=80&v=4"},"commit":{"message":"Clearer naming for new constants","shortMessageHtmlLink":"Clearer naming for new constants"}},{"before":"2d16efee71ae195a6aef2fb36f5ed60768d78c98","after":"8fb6dc4f5ee9e7c8abf43faf366fcae1792139d9","ref":"refs/heads/main","pushedAt":"2023-12-30T10:55:29.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"nadimkobeissi","name":"Nadim Kobeissi","path":"/nadimkobeissi","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/9953?s=80&v=4"},"commit":{"message":"Update dependency","shortMessageHtmlLink":"Update dependency"}},{"before":"ec053c2ca4628fdcce76384a13f511c6eed11444","after":"2d16efee71ae195a6aef2fb36f5ed60768d78c98","ref":"refs/heads/main","pushedAt":"2023-12-30T10:42:17.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"nadimkobeissi","name":"Nadim Kobeissi","path":"/nadimkobeissi","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/9953?s=80&v=4"},"commit":{"message":"Remove additional unsafe divisions by paramsQ\n\nThis commit some more divisions by Q in polyCompress and\npolyvecCompress, after those were reported by Prasanna Ravi and Matthias\nJ. Kannwischer:\n\nhttps://groups.google.com/a/list.nist.gov/g/pqc-forum/c/ldX0ThYJuBo\n\nThis patch mirrors the technique used to patch the vulnerability in the\noriginal Kyber reference implementation:\n\nhttps://github.com/pq-crystals/kyber/commit/dda29cc63af721981ee2c831cf00822e69be3220\n\nThanks to Peter Schwabe for the heads-up.","shortMessageHtmlLink":"Remove additional unsafe divisions by paramsQ"}},{"before":"f7a41f85e90f07053c88d8f985dd6736976b1371","after":"ec053c2ca4628fdcce76384a13f511c6eed11444","ref":"refs/heads/main","pushedAt":"2023-12-19T11:50:50.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"nadimkobeissi","name":"Nadim Kobeissi","path":"/nadimkobeissi","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/9953?s=80&v=4"},"commit":{"message":"Update README.md","shortMessageHtmlLink":"Update README.md"}},{"before":"fe8543e1445563c38e03073a02efc9f109519a88","after":"f7a41f85e90f07053c88d8f985dd6736976b1371","ref":"refs/heads/main","pushedAt":"2023-12-19T11:31:02.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"nadimkobeissi","name":"Nadim Kobeissi","path":"/nadimkobeissi","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/9953?s=80&v=4"},"commit":{"message":"Cleaner fix for #5","shortMessageHtmlLink":"Cleaner fix for <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2028292892\" data-permission-text=\"Title is private\" data-url=\"https://github.com/symbolicsoft/kyber-k2so/issues/5\" data-hovercard-type=\"issue\" data-hovercard-url=\"/symbolicsoft/kyber-k2so/issues/5/hovercard\" href=\"https://github.com/symbolicsoft/kyber-k2so/issues/5\">#5</a>"}},{"before":"a74889e68c31f20a67ceddfd8f142ec812f72f06","after":"fe8543e1445563c38e03073a02efc9f109519a88","ref":"refs/heads/main","pushedAt":"2023-12-17T11:11:42.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"nadimkobeissi","name":"Nadim Kobeissi","path":"/nadimkobeissi","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/9953?s=80&v=4"},"commit":{"message":"Performance optimizations","shortMessageHtmlLink":"Performance optimizations"}},{"before":"b8771fb64e2418bdeb1c310400618ad5ac24823f","after":"a74889e68c31f20a67ceddfd8f142ec812f72f06","ref":"refs/heads/main","pushedAt":"2023-12-17T09:54:42.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"nadimkobeissi","name":"Nadim Kobeissi","path":"/nadimkobeissi","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/9953?s=80&v=4"},"commit":{"message":"Update .golangci.yml","shortMessageHtmlLink":"Update .golangci.yml"}},{"before":"01d803217069c2bb394ea45cebe1ae05cbf33380","after":"b8771fb64e2418bdeb1c310400618ad5ac24823f","ref":"refs/heads/main","pushedAt":"2023-12-17T09:39:43.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"nadimkobeissi","name":"Nadim Kobeissi","path":"/nadimkobeissi","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/9953?s=80&v=4"},"commit":{"message":"Update GitHub workflow","shortMessageHtmlLink":"Update GitHub workflow"}},{"before":"cb4ea5e756e70b5dbb932a0aa7e6391cfc7b8ad5","after":"01d803217069c2bb394ea45cebe1ae05cbf33380","ref":"refs/heads/main","pushedAt":"2023-12-17T09:38:47.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"nadimkobeissi","name":"Nadim Kobeissi","path":"/nadimkobeissi","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/9953?s=80&v=4"},"commit":{"message":"Update GitHub workflow","shortMessageHtmlLink":"Update GitHub workflow"}},{"before":"a641523f0ed692744e42727d531456f25ef3a7ed","after":"cb4ea5e756e70b5dbb932a0aa7e6391cfc7b8ad5","ref":"refs/heads/main","pushedAt":"2023-12-17T09:37:46.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"nadimkobeissi","name":"Nadim Kobeissi","path":"/nadimkobeissi","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/9953?s=80&v=4"},"commit":{"message":"Update copyright header","shortMessageHtmlLink":"Update copyright header"}},{"before":"24b34685f52c861d66b3849ab5329b3103796d77","after":null,"ref":"refs/heads/q-div-timing-fix","pushedAt":"2023-12-17T09:36:52.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"nadimkobeissi","name":"Nadim Kobeissi","path":"/nadimkobeissi","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/9953?s=80&v=4"}},{"before":"ffaf2ee82ba71d2ed80e063595715e6dcfb345d0","after":"a641523f0ed692744e42727d531456f25ef3a7ed","ref":"refs/heads/main","pushedAt":"2023-12-17T09:36:49.000Z","pushType":"pr_merge","commitsCount":3,"pusher":{"login":"nadimkobeissi","name":"Nadim Kobeissi","path":"/nadimkobeissi","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/9953?s=80&v=4"},"commit":{"message":"Merge pull request #9 from symbolicsoft/q-div-timing-fix\n\nRemove possible variable-time division","shortMessageHtmlLink":"Merge pull request <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2045146606\" data-permission-text=\"Title is private\" data-url=\"https://github.com/symbolicsoft/kyber-k2so/issues/9\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/symbolicsoft/kyber-k2so/pull/9/hovercard\" href=\"https://github.com/symbolicsoft/kyber-k2so/pull/9\">#9</a> from symbolicsoft/q-div-timing-fix"}},{"before":null,"after":"24b34685f52c861d66b3849ab5329b3103796d77","ref":"refs/heads/q-div-timing-fix","pushedAt":"2023-12-17T09:35:58.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"nadimkobeissi","name":"Nadim Kobeissi","path":"/nadimkobeissi","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/9953?s=80&v=4"},"commit":{"message":"Finalize fix","shortMessageHtmlLink":"Finalize fix"}},{"before":"758017baf5f5c2588dfd2b208983e293884c09d6","after":null,"ref":"refs/heads/master","pushedAt":"2023-12-17T09:35:23.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"nadimkobeissi","name":"Nadim Kobeissi","path":"/nadimkobeissi","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/9953?s=80&v=4"}},{"before":null,"after":"ffaf2ee82ba71d2ed80e063595715e6dcfb345d0","ref":"refs/heads/main","pushedAt":"2023-12-17T09:34:43.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"nadimkobeissi","name":"Nadim Kobeissi","path":"/nadimkobeissi","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/9953?s=80&v=4"},"commit":{"message":"Update dependencies","shortMessageHtmlLink":"Update dependencies"}},{"before":"24b34685f52c861d66b3849ab5329b3103796d77","after":null,"ref":"refs/heads/q-div-timing-fix","pushedAt":"2023-12-17T09:31:24.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"nadimkobeissi","name":"Nadim Kobeissi","path":"/nadimkobeissi","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/9953?s=80&v=4"}},{"before":"ffaf2ee82ba71d2ed80e063595715e6dcfb345d0","after":"758017baf5f5c2588dfd2b208983e293884c09d6","ref":"refs/heads/master","pushedAt":"2023-12-17T09:31:21.000Z","pushType":"pr_merge","commitsCount":3,"pusher":{"login":"nadimkobeissi","name":"Nadim Kobeissi","path":"/nadimkobeissi","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/9953?s=80&v=4"},"commit":{"message":"Merge pull request #8 from symbolicsoft/q-div-timing-fix\n\nRemove possible variable-time division","shortMessageHtmlLink":"Merge pull request <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2044485896\" data-permission-text=\"Title is private\" data-url=\"https://github.com/symbolicsoft/kyber-k2so/issues/8\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/symbolicsoft/kyber-k2so/pull/8/hovercard\" href=\"https://github.com/symbolicsoft/kyber-k2so/pull/8\">#8</a> from symbolicsoft/q-div-timing-fix"}},{"before":"1a43e07ed51868dd58044c3e148c06cc88814df9","after":"24b34685f52c861d66b3849ab5329b3103796d77","ref":"refs/heads/q-div-timing-fix","pushedAt":"2023-12-17T09:29:12.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"nadimkobeissi","name":"Nadim Kobeissi","path":"/nadimkobeissi","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/9953?s=80&v=4"},"commit":{"message":"Finalize fix","shortMessageHtmlLink":"Finalize fix"}},{"before":null,"after":"1a43e07ed51868dd58044c3e148c06cc88814df9","ref":"refs/heads/q-div-timing-fix","pushedAt":"2023-12-15T23:19:49.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"nadimkobeissi","name":"Nadim Kobeissi","path":"/nadimkobeissi","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/9953?s=80&v=4"},"commit":{"message":"Remove possible variable-time division\n\nThis commit removes a potential variable-time division which may occur\nin `polyToMsg`. The fix is based on the following change to the\nreference code:\n\nhttps://github.com/pq-crystals/kyber/commit/dda29cc63af721981ee2c831cf00822e69be3220\n\nThe above fix to the reference code appears to have come as a result of\nthe issue being reported to the Kyber team by the Cryspen team (Goutam\nTavada, Karthikeyan Bhargavan and Franziskus Kiefer).\n\nThe variable-time division first made it into Kyber-K2SO as a result of\nthis code being based on the Kyber reference implementation from which\nwe copy the fix here.\n\nFinally, fixing this issue appears to negatively impact performance\nbenchmarks. Before the fix:\n\ngoos: linux\ngoarch: amd64\npkg: github.com/symbolicsoft/kyber-k2so\ncpu: 13th Gen Intel(R) Core(TM) i7-1360P\nBenchmarkKemKeypair512-16          17241             58059 ns/op\nBenchmarkKemKeypair768-16           9544            111643 ns/op\nBenchmarkKemKeypair1024-16          6648            156460 ns/op\nBenchmarkKemEncrypt512-16          16389             76382 ns/op\nBenchmarkKemEncrypt768-16          10000            122497 ns/op\nBenchmarkKemEncrypt1024-16          5888            178981 ns/op\nBenchmarkKemDecrypt512-16          13976             85318 ns/op\nBenchmarkKemDecrypt768-16           8008            137430 ns/op\nBenchmarkKemDecrypt1024-16          5558            202413 ns/op\nPASS\nok      github.com/symbolicsoft/kyber-k2so      13.837s\n\nAfter the fix:\n\ngoos: linux\ngoarch: amd64\npkg: github.com/symbolicsoft/kyber-k2so\ncpu: 13th Gen Intel(R) Core(TM) i7-1360P\nBenchmarkKemKeypair512-16          20779             56627 ns/op\nBenchmarkKemKeypair768-16          12062             99456 ns/op\nBenchmarkKemKeypair1024-16          7518            154263 ns/op\nBenchmarkKemEncrypt512-16          15798             70288 ns/op\nBenchmarkKemEncrypt768-16           8662            121981 ns/op\nBenchmarkKemEncrypt1024-16          6547            179181 ns/op\nBenchmarkKemDecrypt512-16          14059             84058 ns/op\nBenchmarkKemDecrypt768-16           8001            136209 ns/op\nBenchmarkKemDecrypt1024-16          4869            225456 ns/op\nPASS\nok      github.com/symbolicsoft/kyber-k2so      16.006s\n\nRelevant issue #7 in the Kyber-K2SO repository:\nhttps://github.com/symbolicsoft/kyber-k2so/issues/7","shortMessageHtmlLink":"Remove possible variable-time division"}},{"before":"ba5df7eec2893554f87f7a8cc2115ecd3eb0a45d","after":"ffaf2ee82ba71d2ed80e063595715e6dcfb345d0","ref":"refs/heads/master","pushedAt":"2023-12-12T20:19:27.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"nadimkobeissi","name":"Nadim Kobeissi","path":"/nadimkobeissi","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/9953?s=80&v=4"},"commit":{"message":"Update dependencies","shortMessageHtmlLink":"Update dependencies"}},{"before":"9e394b2eb503c1f3948f931f527499246b55524d","after":"ba5df7eec2893554f87f7a8cc2115ecd3eb0a45d","ref":"refs/heads/master","pushedAt":"2023-12-12T20:15:18.000Z","pushType":"pr_merge","commitsCount":2,"pusher":{"login":"nadimkobeissi","name":"Nadim Kobeissi","path":"/nadimkobeissi","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/9953?s=80&v=4"},"commit":{"message":"Merge pull request #6 from parazyd/noiseseed-fix\n\nMake sure that the buffer passed to indcpaGenMatrix isn't modified","shortMessageHtmlLink":"Merge pull request <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2028352268\" data-permission-text=\"Title is private\" data-url=\"https://github.com/symbolicsoft/kyber-k2so/issues/6\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/symbolicsoft/kyber-k2so/pull/6/hovercard\" href=\"https://github.com/symbolicsoft/kyber-k2so/pull/6\">#6</a> from parazyd/noiseseed-fix"}},{"before":"1e6bb53d23c9e4e61d2e8d932128c2993528914d","after":"9e394b2eb503c1f3948f931f527499246b55524d","ref":"refs/heads/master","pushedAt":"2023-03-23T01:06:02.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"nadimkobeissi","name":"Nadim Kobeissi","path":"/nadimkobeissi","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/9953?s=80&v=4"},"commit":{"message":"Go toolchain updates","shortMessageHtmlLink":"Go toolchain updates"}}],"hasNextPage":false,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"djE6ks8AAAAD1VjjHAA","startCursor":null,"endCursor":null}},"title":"Activity · symbolicsoft/kyber-k2so"}