From 9d5d453a68f0c2755aa90c6c2c38e7f089791619 Mon Sep 17 00:00:00 2001 From: Douglas Date: Thu, 20 Aug 2020 08:00:32 -0300 Subject: [PATCH] Better HTTP error codes It's better to use 401 for lack of permission and 409 if the user already exists https://developer.mozilla.org/en-US/docs/Web/HTTP/Status/401 https://developer.mozilla.org/en-US/docs/Web/HTTP/Status/409 --- .../backend/app/app/api/api_v1/endpoints/users.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/{{cookiecutter.project_slug}}/backend/app/app/api/api_v1/endpoints/users.py b/{{cookiecutter.project_slug}}/backend/app/app/api/api_v1/endpoints/users.py index c8f89b63d8..c9cd5f4043 100644 --- a/{{cookiecutter.project_slug}}/backend/app/app/api/api_v1/endpoints/users.py +++ b/{{cookiecutter.project_slug}}/backend/app/app/api/api_v1/endpoints/users.py @@ -40,7 +40,7 @@ def create_user( user = crud.user.get_by_email(db, email=user_in.email) if user: raise HTTPException( - status_code=400, + status_code=409, detail="The user with this username already exists in the system.", ) user = crud.user.create(db, obj_in=user_in) @@ -105,7 +105,7 @@ def create_user_open( user = crud.user.get_by_email(db, email=email) if user: raise HTTPException( - status_code=400, + status_code=409, detail="The user with this username already exists in the system", ) user_in = schemas.UserCreate(password=password, email=email, full_name=full_name) @@ -127,7 +127,7 @@ def read_user_by_id( return user if not crud.user.is_superuser(current_user): raise HTTPException( - status_code=400, detail="The user doesn't have enough privileges" + status_code=401, detail="The user doesn't have enough privileges" ) return user