{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":481331916,"defaultBranch":"main","name":"move","ownerLogin":"tnowacki","currentUserCanPush":false,"isFork":true,"isEmpty":false,"createdAt":"2022-04-13T18:32:55.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/1753366?v=4","public":true,"private":false,"isOrgOwned":false},"refInfo":{"name":"","listCacheKey":"v0:1681341576.0","currentOid":""},"activityList":{"items":[{"before":"f78c78c62518547b2b91577e7df1ffc7d79ec7c6","after":null,"ref":"refs/heads/offset-fix","pushedAt":"2023-04-12T23:19:36.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"tnowacki","name":"Todd Nowacki","path":"/tnowacki","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1753366?s=80&v=4"}},{"before":"e66fc06cad2bddf9e2800caf0f20af5d29b2cf93","after":"f78c78c62518547b2b91577e7df1ffc7d79ec7c6","ref":"refs/heads/offset-fix","pushedAt":"2023-04-12T21:43:19.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"tnowacki","name":"Todd Nowacki","path":"/tnowacki","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1753366?s=80&v=4"},"commit":{"message":"[bug fix] Remove incorrect overflow guard\n\n- Removed incorrect overflow guard\n- Added tests","shortMessageHtmlLink":"[bug fix] Remove incorrect overflow guard"}},{"before":null,"after":"e66fc06cad2bddf9e2800caf0f20af5d29b2cf93","ref":"refs/heads/offset-fix","pushedAt":"2023-04-12T21:17:28.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"tnowacki","name":"Todd Nowacki","path":"/tnowacki","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1753366?s=80&v=4"},"commit":{"message":"Improve index check for successors","shortMessageHtmlLink":"Improve index check for successors"}},{"before":"dd68cceec4ee9cf7b9343d7ccb6d0ae5a9db3f46","after":"0151500f3fd3d6c2617f4b95f1bd88477d604c80","ref":"refs/heads/main","pushedAt":"2023-04-12T21:15:50.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"tnowacki","name":"Todd Nowacki","path":"/tnowacki","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1753366?s=80&v=4"},"commit":{"message":"Fix typo (#1015)\n\n\"At the end of a function (when `Ret` is reached), *no local* whose type is of resource kind must be empty, i.e., the value must have been moved out of the local.\"\r\nI suppose that should be *any local* instead.","shortMessageHtmlLink":"Fix typo (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"1643185107\" data-permission-text=\"Title is private\" data-url=\"https://github.com/move-language/move/issues/1015\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/move-language/move/pull/1015/hovercard\" href=\"https://github.com/move-language/move/pull/1015\">move-language#1015</a>)"}},{"before":"0151500f3fd3d6c2617f4b95f1bd88477d604c80","after":"dd68cceec4ee9cf7b9343d7ccb6d0ae5a9db3f46","ref":"refs/heads/main","pushedAt":"2023-04-06T09:48:18.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"tnowacki","name":"Todd Nowacki","path":"/tnowacki","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1753366?s=80&v=4"},"commit":{"message":"[move-binary-format] Support changing of signatures for private entry functions (#1012)\n\nAdds a new flag `check_private_entry_linking` that when true checks the\r\nprivate entry function signatures cannot change. E.g.,\r\n\r\nIf we had\r\n\r\n```\r\nentry fun fn() { }\r\n```\r\n\r\nand\r\n\r\n```\r\nentry fun fn(_x: u64) { }\r\n```\r\n\r\nThese would be compatible if `check_private_entry_linking` was set to\r\n`false` but ruled incompatible if `check_private_entry_linking` was set\r\nto `true`.","shortMessageHtmlLink":"[move-binary-format] Support changing of signatures for private entry…"}},{"before":"3bf48f9a30cc06d3ceb8e8af639d9dd7ad96fdca","after":"0151500f3fd3d6c2617f4b95f1bd88477d604c80","ref":"refs/heads/main","pushedAt":"2023-03-30T23:18:46.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"tnowacki","name":"Todd Nowacki","path":"/tnowacki","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1753366?s=80&v=4"},"commit":{"message":"Fix typo (#1015)\n\n\"At the end of a function (when `Ret` is reached), *no local* whose type is of resource kind must be empty, i.e., the value must have been moved out of the local.\"\r\nI suppose that should be *any local* instead.","shortMessageHtmlLink":"Fix typo (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"1643185107\" data-permission-text=\"Title is private\" data-url=\"https://github.com/move-language/move/issues/1015\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/move-language/move/pull/1015/hovercard\" href=\"https://github.com/move-language/move/pull/1015\">move-language#1015</a>)"}},{"before":"60cec12b1ed9382836aa4c141e445656d39375e1","after":"3bf48f9a30cc06d3ceb8e8af639d9dd7ad96fdca","ref":"refs/heads/main","pushedAt":"2023-03-30T23:11:43.000Z","pushType":"push","commitsCount":5,"pusher":{"login":"tnowacki","name":"Todd Nowacki","path":"/tnowacki","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1753366?s=80&v=4"},"commit":{"message":"[session] Expose struct loading (#1022)\n\nThis operation loads the struct type information.  It differs from\r\n`load_type` which, when loading a generic struct type, will also\r\ninstantiate type parameters.\r\n\r\nTest Plan:\r\n\r\n```\r\n$ env SOLC=... cargo nextest --no-fail-fast\r\n```","shortMessageHtmlLink":"[session] Expose struct loading (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"1645811157\" data-permission-text=\"Title is private\" data-url=\"https://github.com/move-language/move/issues/1022\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/move-language/move/pull/1022/hovercard\" href=\"https://github.com/move-language/move/pull/1022\">move-language#1022</a>)"}},{"before":"8ac55a5e1723323548ae2942f3249f6304c13342","after":null,"ref":"refs/heads/pub-compile","pushedAt":"2023-03-28T18:26:24.401Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"tnowacki","name":"Todd Nowacki","path":"/tnowacki","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1753366?s=80&v=4"}},{"before":null,"after":"8ac55a5e1723323548ae2942f3249f6304c13342","ref":"refs/heads/pub-compile","pushedAt":"2023-03-28T17:59:49.881Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"tnowacki","name":"Todd Nowacki","path":"/tnowacki","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1753366?s=80&v=4"},"commit":{"message":"[transactional tests] Support multi module publishing\n\n- This probably should have been done a while ago...","shortMessageHtmlLink":"[transactional tests] Support multi module publishing"}},{"before":"f3cab72c7b7401de34a2d4c4ac86f9e402256e25","after":"60cec12b1ed9382836aa4c141e445656d39375e1","ref":"refs/heads/main","pushedAt":"2023-03-27T17:29:16.118Z","pushType":"push","commitsCount":9,"pusher":{"login":"tnowacki","name":"Todd Nowacki","path":"/tnowacki","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1753366?s=80&v=4"},"commit":{"message":"[loader] Remove double-insertion invariant violation (#1007)\n\nTurns out that we already double insert into the loader: when two\r\nrequests to load a module come in at the same time, both will find the\r\nloaded and compiled module caches empty, so both will start the\r\nprocess of verifying the module and insert it.  The last write wins,\r\nand the older write's `binaries` entry leaks.\r\n\r\nRemoving the invariant violation check, and accepting that we will\r\nsometimes leak entries as the alternative is to hold the lock for\r\nlonger in the critical path, which will be too detrimental for\r\nperformance.\r\n\r\nTest Plan:\r\n\r\n```\r\n$ cargo nextest\r\n```\r\n\r\n+ Run the Sui-specific stress-test benchmark that uncovered this issue.","shortMessageHtmlLink":"[loader] Remove double-insertion invariant violation (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"1639586323\" data-permission-text=\"Title is private\" data-url=\"https://github.com/move-language/move/issues/1007\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/move-language/move/pull/1007/hovercard\" href=\"https://github.com/move-language/move/pull/1007\">move-language#1007</a>"}},{"before":"b47c1d8955e11ed99842fc40a5425c4198589dce","after":"f3cab72c7b7401de34a2d4c4ac86f9e402256e25","ref":"refs/heads/main","pushedAt":"2023-03-17T19:09:14.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"tnowacki","name":"Todd Nowacki","path":"/tnowacki","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1753366?s=80&v=4"},"commit":{"message":"[interpreter] Fix native as entry point (#985)\n\n* [interpreter] Fix native as entry point\r\n\r\n- interpreter entrypoint did not handle the case where the function is native","shortMessageHtmlLink":"[interpreter] Fix native as entry point (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"1626362412\" data-permission-text=\"Title is private\" data-url=\"https://github.com/move-language/move/issues/985\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/move-language/move/pull/985/hovercard\" href=\"https://github.com/move-language/move/pull/985\">move-language#985</a>)"}},{"before":"24098062418fb1cf5001f738ddfa78405dec3e24","after":null,"ref":"refs/heads/call-native","pushedAt":"2023-03-16T05:01:04.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"tnowacki","name":"Todd Nowacki","path":"/tnowacki","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1753366?s=80&v=4"}},{"before":"616135b1c6ab8d3bdbf83c58850743e3b923ff53","after":"24098062418fb1cf5001f738ddfa78405dec3e24","ref":"refs/heads/call-native","pushedAt":"2023-03-16T04:27:25.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"tnowacki","name":"Todd Nowacki","path":"/tnowacki","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1753366?s=80&v=4"},"commit":{"message":"fixup! remove test panics","shortMessageHtmlLink":"fixup! remove test panics"}},{"before":"33800c9cd3f1fe40d43f67596dface8e4e5941d0","after":"616135b1c6ab8d3bdbf83c58850743e3b923ff53","ref":"refs/heads/call-native","pushedAt":"2023-03-16T00:15:25.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"tnowacki","name":"Todd Nowacki","path":"/tnowacki","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1753366?s=80&v=4"},"commit":{"message":"remove test panics","shortMessageHtmlLink":"remove test panics"}},{"before":null,"after":"33800c9cd3f1fe40d43f67596dface8e4e5941d0","ref":"refs/heads/call-native","pushedAt":"2023-03-15T22:15:04.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"tnowacki","name":"Todd Nowacki","path":"/tnowacki","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1753366?s=80&v=4"},"commit":{"message":"[interpreter] Fix native as entry point\n\n- interpreter entrypoint did not handle the case where the function is native","shortMessageHtmlLink":"[interpreter] Fix native as entry point"}},{"before":"548f98949cc23c303a38976bda251fdcdcc5cfc4","after":"b47c1d8955e11ed99842fc40a5425c4198589dce","ref":"refs/heads/main","pushedAt":"2023-03-15T21:43:12.000Z","pushType":"push","commitsCount":11,"pusher":{"login":"tnowacki","name":"Todd Nowacki","path":"/tnowacki","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1753366?s=80&v=4"},"commit":{"message":"[loader] Remove features not relevant for Sui (#973)\n\nRemove support for\r\n\r\n- republishing an existing module or doing a compatibility check in that \r\n   case in `session` and `loader`.  \r\n- invalidating the loader because a module has been republished.\r\n- checking for cycles among friends.\r\n \r\nThese codepaths are never used by Sui, which does not permit republishing \r\nat the same address except in very specific edge cases that are handled \r\nexternally, and continuing to support these codepaths will further complicate\r\nsupport for package upgrades (i.e. republishing) on Sui.\r\n\r\nThis PR also removes any test that relies on or tests republishing, as well as \r\nsupport in the sandbox for republishing and/or compatibility checks\r\n\r\n## Test Plan\r\n\r\n```\r\nmove$ cargo nextest\r\nmove$ cargo test --workspace\r\n```","shortMessageHtmlLink":"[loader] Remove features not relevant for Sui (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"1619367047\" data-permission-text=\"Title is private\" data-url=\"https://github.com/move-language/move/issues/973\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/move-language/move/pull/973/hovercard\" href=\"https://github.com/move-language/move/pull/973\">move-language#973</a>)"}}],"hasNextPage":false,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"djE6ks8AAAADF46HkAA","startCursor":null,"endCursor":null}},"title":"Activity · tnowacki/move"}