-
Notifications
You must be signed in to change notification settings - Fork 94
Named modules, Diffing + legacy code #29
Comments
Hi thanks for the feedback! @apercu I'll let you weigh in on the first half |
Hey! Yeah definitely for the named modules, I'll add that thanks! About the diff highlighting though I'm a bit concerned we will have to show all the components at every stage to do a complete diffing of it and that might be a bit big, unless you had a better idea? |
@apercu Yeah, it could take a lot of space, maybe just show 2 or 3 lines above and below the change? Check for example webpack docs pages: https://webpack.js.org/guides/code-splitting/ |
Thanks for the tutorials and thanks for deck.gl it is great but in the basic chart we add the Spinner component it is giving me an error ReferenceError: Spinner is not defined. |
@nharrisanalyst Check parent folder contents, everything is there, just copy and paste it to your folder |
thanks |
I just finished the first tutorial, amazing stuff! Been waiting for doing something like this but never found a good place to start, now I have it. Thanks for coming up with this academy!
I want to leave some feedback after finishing it:
renderer.code
hook: https://gist.github.com/choxi/6fa98f7b203bf2dfdcfa (source highlight as diff and language highlightjs/highlight.js#480)Spinner
is used but never importedhoveredObject
is used inrender
, but never declared, same with a function called_onHover
I could contribute to some of those changes if you agree with them :)
The text was updated successfully, but these errors were encountered: