Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adding shimmer when the ratings are loading. #1525

Merged
merged 2 commits into from
Aug 16, 2024

Conversation

BLKKKBVSIK
Copy link
Collaborator

In this PR:

  • Adding shimmers placeholder text during the loading of the ratings.

fix #1447

Screencast.from.2023-12-12.11-54-14.webm

@anasereijo
Copy link
Collaborator

Could we just have the whole page loading using a skeleton loader?

@BLKKKBVSIK
Copy link
Collaborator Author

BLKKKBVSIK commented Dec 13, 2023

Could we just have the whole page loading using a skeleton loader?

Except for the ratings, there is nothing that needs loading on the package page.
If the styling of the shimmer effect is a no-go, I can update it.

@anasereijo
Copy link
Collaborator

@BLKKKBVSIK, I think it looks odd using the skeleton (shimmer) just on the ratings, as it's only loading a tiny fraction of the screen.
I think we should force the whole section to be skeleton until everything in there is ready to be loaded (in this case, ratings).
It's more perceptive that it's loading information, and the order we want users to read the content is kept (ratings first)

Screenshot 2023-12-13 at 14 29 28

@d-loose
Copy link
Member

d-loose commented Dec 15, 2023

However, all the other information is available immediately and doesn't need any loading indicator. It'd be a shame if we had to add a skeleton loader just because of the ratings 😢

@spydon spydon closed this Aug 16, 2024
@anasereijo
Copy link
Collaborator

Let's merge this as discussed :D

@spydon spydon reopened this Aug 16, 2024
@spydon spydon force-pushed the feat/shimmer-ratings-loading branch from dc76760 to cf75cd9 Compare August 16, 2024 12:37
@spydon spydon merged commit 0c8d239 into main Aug 16, 2024
8 checks passed
@spydon spydon deleted the feat/shimmer-ratings-loading branch August 16, 2024 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Widgets on the snap page move around during initialization
4 participants