Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Track active changes in the application and show list in manage page. #1535

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

codinesh
Copy link
Contributor

Fixes #1438, by displaying a section for installing/uninstalling snaps.

image

To Listen to the changes from Snap details page, tapped on to SnapModel._activeChangeListener to know the installs, uninstalls and change updates. This will call the ManageModel to maintain the list of active snaps.
Scope of this change to track the changes made from this app, as a workaround to an issue in /v2/changes api, which doesn't give enough information to identify corresponding snap from the response.

Workaround is discussed #1438 (comment).

Here is link to accidentally closed original PR with some discussions. Current PR is created with code changes from original PR.

@codinesh
Copy link
Contributor Author

Requesting @d-loose, @BLKKKBVSIK and @anasereijo to review this PR instead of #1517.

Thanks for understanding.

Copy link

github-actions bot commented Dec 20, 2023

Everyone contributing to this PR have now signed the CLA. Thanks!

@BLKKKBVSIK
Copy link
Collaborator

LGTM !
Let's just wait until @anasereijo comes back from holidays to see if the UI changes are approuved :)

@codinesh
Copy link
Contributor Author

Sounds good, thanks.

@anasereijo
Copy link
Collaborator

anasereijo commented Jan 2, 2024

Great work @codinesh! Just a few points:

  • when there are no apps being installed, this section will be hidden, correct?
  • would be nice to display the option to cancel the installation
  • maybe we can remove the more options button [ ... ] since it's probably not very useful or no actions to be taken while the installation is in progress

did a quick mock-up of how it could look like:

Screenshot 2024-01-02 at 16 03 20

Thank you

@codinesh
Copy link
Contributor Author

codinesh commented Jan 2, 2024

Great work @codinesh! Just a few points:

  • when there are no apps being installed, this section will be hidden, correct?

Yes, that is the behavior..

Thanks for suggestions on additional options and the Cancel button, will take up these changes.

Will match figma. Thank you.

@codinesh
Copy link
Contributor Author

codinesh commented Jan 3, 2024

Hello @anasereijo,

maybe we can remove the more options button [ ... ] since it's probably not very useful or no actions to be taken while the installation is in progress

Should we keep the [...] options button to make it consistent with other two sections. Please see the screenshot. Since the item is to open, will be navigated to snap detail page.

Please let me know what you thing, change is simple in any case.

Screenshot from 2024-01-03 19-42-23

Thank you

@codinesh
Copy link
Contributor Author

Hello @anasereijo,

maybe we can remove the more options button [ ... ] since it's probably not very useful or no actions to be taken while the installation is in progress

Should we keep the [...] options button to make it consistent with other two sections. Please see the screenshot. Since the item is to open, will be navigated to snap detail page.

Please let me know what you thing, change is simple in any case.

Screenshot from 2024-01-03 19-42-23

Thank you

Hi @anasereijo please have a look at this comment and share your opinion.

@anasereijo
Copy link
Collaborator

Hi @codinesh, apologies for my late reply.

Good catch! we should keep consistency with the other sections indeed. so lets keep the button [ ... ] whilst the snap is installing.

thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Track active changes throughout the application
3 participants