-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Track active changes in the application and show list in manage page. #1535
base: main
Are you sure you want to change the base?
Conversation
… changed, tests and localization strings.
Requesting @d-loose, @BLKKKBVSIK and @anasereijo to review this PR instead of #1517. Thanks for understanding. |
Everyone contributing to this PR have now signed the CLA. Thanks! |
109b7aa
to
fdc742c
Compare
fdc742c
to
4d842d2
Compare
LGTM ! |
Sounds good, thanks. |
Great work @codinesh! Just a few points:
did a quick mock-up of how it could look like: ![]() Thank you |
Yes, that is the behavior.. Thanks for suggestions on additional options and the Cancel button, will take up these changes. Will match figma. Thank you. |
Hello @anasereijo,
Should we keep the [...] options button to make it consistent with other two sections. Please see the screenshot. Since the item is to open, will be navigated to snap detail page. Please let me know what you thing, change is simple in any case. Thank you |
Hi @anasereijo please have a look at this comment and share your opinion. |
Hi @codinesh, apologies for my late reply. Good catch! we should keep consistency with the other sections indeed. so lets keep the button [ ... ] whilst the snap is installing. thank you! |
Fixes #1438, by displaying a section for installing/uninstalling snaps.
To Listen to the changes from Snap details page, tapped on to SnapModel._activeChangeListener to know the installs, uninstalls and change updates. This will call the ManageModel to maintain the list of active snaps.
Scope of this change to track the changes made from this app, as a workaround to an issue in /v2/changes api, which doesn't give enough information to identify corresponding snap from the response.
Workaround is discussed #1438 (comment).
Here is link to accidentally closed original PR with some discussions. Current PR is created with code changes from original PR.