-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add GitHub Action to upload complete source tarball #279
base: main
Are you sure you want to change the base?
Conversation
I've created a bunch of tags and releases in my fork; after cloning all your repositories so that the hook would finish recursively cloning all submodules (from my account), https://github.com/klemensn/web-eid-app/actions/runs/5561964558/jobs/10159971653#step:4:10 shows that the actual upload action usage needs fixing. |
1842aa1
to
b0cb52f
Compare
If used on the current release, this would've created
I've tested this with releases on my fork. |
Excellent, thank you! We will merge this during the v2.5 development cycle which will begin in end of July/beginning of August. |
That means the next v2.4 release won't get a tarball generated by this, right? |
b0cb52f
to
419eb16
Compare
Yes, that's correct, the v2.4 release doesn't have an automatically generated tarball. Sure, we'll ensure to upload one manually when time allows. |
419eb16
to
f6a2965
Compare
f6a2965
to
e40b56d
Compare
Contrary to auto-generated release tarballs, this one includes all submodules such that operating system infrastructure gets a complete source tree wihtout having to fetch submodules themself. Add "-full" between name and version to distinguish the two tarballs. The token needs read/write permissions to clone the repository and upload assets to existing releases, respectively. Fixes web-eid#274 Signed-off-by: Klemens Nanni <[email protected]>
e40b56d
to
d0b4a64
Compare
Friendly ping, I also rebased onto latest master as suggested by GitHub. |
Signed-off-by: Klemens Nanni [email protected]