[EyeDropper API] Add optional AbortSignal parameter to EyeDropper.open #30696
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Sep 13, 2021
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-3152761
branch
2 times, most recently
from
a02cd5f
to
8efc577
Compare
Per TAG review[1], this CL adds an optional AbortSignal parameter to EyeDropper.open to allow authors to dismiss the eyedropper with no selection in case another high-priority event occurs. [1]: w3ctag/design-reviews#587 (comment) Bug: 1248286 Change-Id: I15580609ece85f947f019a724b23b5e4898e42f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3152761 Commit-Queue: Ionel Popescu <[email protected]> Reviewed-by: Mason Freed <[email protected]> Cr-Commit-Position: refs/heads/main@{#920997}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-3152761
branch
from
8efc577
to
3bb3350
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per TAG review1, this CL adds an optional AbortSignal parameter to
EyeDropper.open to allow authors to dismiss the eyedropper with no
selection in case another high-priority event occurs.
Bug: 1248286
Change-Id: I15580609ece85f947f019a724b23b5e4898e42f2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3152761
Commit-Queue: Ionel Popescu <[email protected]>
Reviewed-by: Mason Freed <[email protected]>
Cr-Commit-Position: refs/heads/main@{#920997}