From 25a4eb33a6490f5f2ea6cb1a0dcfcda35dd9a1bf Mon Sep 17 00:00:00 2001 From: "xiemaomao520@163.com" Date: Sun, 22 Jul 2018 00:01:20 +0800 Subject: [PATCH 1/2] The `handle` method have a return type of `ResponseInterface`, so it was never be executed. --- src/Middleware/ErrorHandler.php | 4 ---- 1 file changed, 4 deletions(-) diff --git a/src/Middleware/ErrorHandler.php b/src/Middleware/ErrorHandler.php index f94c677..5832806 100644 --- a/src/Middleware/ErrorHandler.php +++ b/src/Middleware/ErrorHandler.php @@ -141,10 +141,6 @@ public function process(ServerRequestInterface $request, RequestHandlerInterface try { $response = $handler->handle($request); - - if (! $response instanceof ResponseInterface) { - throw new MissingResponseException('Application did not return a response'); - } } catch (Throwable $e) { $response = $this->handleThrowable($e, $request); } From f8c19ac8086f4a1f8833798f9511a182f56e62a4 Mon Sep 17 00:00:00 2001 From: Matthew Weier O'Phinney Date: Tue, 24 Jul 2018 15:11:48 -0500 Subject: [PATCH 2/2] Adds CHANGELOG entry for #177 --- CHANGELOG.md | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 67c65c6..340a100 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -22,7 +22,8 @@ details. ### Removed -- Nothing. +- [#177](https://github.com/zendframework/zend-stratigility/pull/177) removes a conditional from `Zend\Stratigility\Middleware\ErrorHandler` that can + never be reached. ### Fixed