From a28b16e69cc006c02cd8e38d869d5958bcc948b5 Mon Sep 17 00:00:00 2001 From: Chris Hennick <4961925+Pr0methean@users.noreply.github.com> Date: Fri, 24 May 2024 15:27:28 -0700 Subject: [PATCH] Apply suggestions from code review Fix errors Signed-off-by: Chris Hennick <4961925+Pr0methean@users.noreply.github.com> --- src/write.rs | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/write.rs b/src/write.rs index f12485764..8e4cce8ab 100644 --- a/src/write.rs +++ b/src/write.rs @@ -796,9 +796,8 @@ impl ZipWriter { extra_field, ); let version_needed = file.version_needed(); - file.version_needed = version_needed; file.version_made_by = file.version_made_by.max(version_needed as u8); - let index = self.insert_file_data(file)?; + let index = self.insert_file_data(file)?; let file = &mut self.files[index]; let writer = self.inner.get_plain();