-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RFC] Experimental suspense+cm router #217
Comments
Should
Is it a normal usecase to render an element when pending is false? I think it would be simpler like this:
|
@mellson yeah, that's a good point! The reason it's designed the way it is is to make it easy to do enter/exit animations on the indicator (keeping one element rendered so you can do regular CSS transitions etc). But it's definitively worth considering! |
Sorry, forget that. I was too fast. It's needed for |
@zth that makes sense. I think keep it as it is. I was just a little confused because the |
Yes, the rationale for splitting in 3 steps is that each step is needed, in the sense that:
The alternative would be to merge This is a very interesting discussion and the thing I've wrestled with the most when working through the current approach. Very happy to discuss it more, weigh pros and cons etc. |
Should the router maybe provide a wrapper around the RescriptReactRouter methods for push and others? It's a bit confusing using two things with so similar names 😆 It would be nice to be able to do one or both of these:
|
Yes, that's a great idea! We should definitely have that. Let me set that up and update the gists. Actually, I'll move the code into the repo (but not expose it in the package for now). Is there anything else around convenience you've thought of? |
@zth that sounds great. I don't have any more inconveniences right now. I think it's a great product you're building! I've played around with preloading data and code, and everything works smoothly. It's so nice, a huge upgrade over the included router when using Relay. |
The code now exists here: https://github.com/zth/rescript-relay/tree/master/packages/rescript-relay/src/experimental-router It also has a |
@zth nice, love the addition of Should that hook include |
I haven't thought about it too much yet, but ideally I would want to split up "static" stuff/actions and things like |
As detailed here: https://rescript-relay-documentation.vercel.app/docs/experimental-router
Please add any thoughts, comments or feedback about the router to this issue.
The text was updated successfully, but these errors were encountered: