Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TEST PR] Oblique forests #10

Closed
wants to merge 24 commits into from
Closed

[TEST PR] Oblique forests #10

wants to merge 24 commits into from

Conversation

adam2392
Copy link
Collaborator

@adam2392 adam2392 commented Sep 1, 2021

Reference Issues/PRs

Test PR to enable CI

What does this implement/fix? Explain your changes.

Any other comments?

@adam2392
Copy link
Collaborator Author

adam2392 commented Sep 1, 2021

Action Items:

Update cython code with the latest optimizations from manifold_random_forests
Add docstrings to all new Python/Cython code
Fix linter
Update unit tests and make them pass.
Write up documentation on this PR, macro/micro changes made and have that ready.
Show a use-case that can extend scikit-learn's pxd files in a "MORF" implementation.

@adam2392 adam2392 changed the title Oblique forests [TEST PR] Oblique forests Sep 1, 2021
ogrisel and others added 24 commits September 1, 2021 17:59
@ogrisel @TomDLT
Make the check changelog message more explicit
d7cecb3
@jameslamb @TomDLT
FIX removes duplicate 'min_data_in_bin' in lightgbm parameters
47b82a5
@thomasjpfan @TomDLT
CLN Removes unneeded return
4cc9fec
@thomasjpfan @TomDLT
ENH Adds n_features_in_ and feature_names_in_ to encoders
701538a
@thomasjpfan @TomDLT
CLN Removes unneeded test
f500326
@adam2392
FIX Remove **params from fit function for FeatureAgglomeration to get…
9a04a27 
… more concise error message (scikit-learn#20899)
DOC fix a spelling mistake in the glossary (scikit-learn#20918)
d6be41b 
Co-authored-by: Ezri Mudde <[email protected]>
@genvalen
DOC use backticks for n_samples and n_features in X docstring (scikit…
6421278 
…-learn#20914)
@timvink
ENH Improve error message for check_estimator with empty data (scikit…
f7a7659 
…-learn#20834)
@kxytim @glemaitre
FIX incorrect component_indices_ in Nystroem (scikit-learn#20554)
6600994 
Co-authored-by: Guillaume Lemaitre <[email protected]>
@glemaitre @thomasjpfan @adrinjalali
MNT replace if_delegate_has_method by available_if in example (scikit…
fac31e7 
…-learn#20684)

Co-authored-by: Thomas J. Fan <[email protected]>
Co-authored-by: Adrin Jalali <[email protected]>
@jmloyola
API Deprecate kwargs in RadiusNeighborsClassifier (scikit-learn#20842)
d270739
@adrinjalali
DOC rebuild authors page (scikit-learn#20924)
1718d63
@jeremiedbb
DOC Add what's new for 20200 for 1.0 (scikit-learn#20927)
267b617 
* add what's new for 20200

* clearer descr
@thomasjpfan
BUG Corrects tag in TfidfTransformer (scikit-learn#20919)
cfc1695
@t-jakubek @jjerphan
Fixing integer overflow on 32-bit architectures. (scikit-learn#20904)
d5215a1 
Co-authored-by: Julien Jerphanion <[email protected]>
@glemaitre
DOC small fixes in what's new 1.0 (scikit-learn#20931 )
5cc2024
@glemaitre @thomasjpfan
@adrinjalali @ogrisel
API add from_estimator and from_predictions to RocCurveDisplay (sciki…
f461908 
…t-learn#20569)

Co-authored-by: Thomas J. Fan <[email protected]>
Co-authored-by: Adrin Jalali <[email protected]>
Co-authored-by: Olivier Grisel <[email protected]>
@adam2392
Adding updated oblique forest code.
12223d2
@adam2392
Clean up
cbfeb35
@adam2392
Working version
51b0679
@adam2392
Black
78557e4
@adam2392
Remove unused code
ab68de0
@adam2392
Fixed precommitt
b94da26
@adam2392 adam2392 closed this Jan 30, 2023
@adam2392 adam2392 deleted the oblique_forests branch March 2, 2023 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.