Tom/grid to graph 26 #8
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…5819) Documenting the changes in scikit-learn#15775
…llowing sklearn guideline (scikit-learn#15778)
* MNT Adds comment regarding coverage pinning * CLN Improves english
…arn#16234) * Isotonic regression docs * remove space * Apply suggestions from code review Co-Authored-By: Thomas J Fan <[email protected]> * Documented auto option in UG * fixed more docstrings * Addressed comments Co-authored-by: Thomas J Fan <[email protected]>
* CLN use pytest raises ctxt manager for class weights & estimators [skip ci] * CLN use pytest raises ctxt manager for multiclass test * CLN use pytest warns in estimator checks test * CLN use pytest raises ctxt manager for random test * CLN use pytest raises ctxt manager for sparsefuncs test * CLN use pytest raises ctxt manager for testing utils tests * CLN use pytest raises ctxt manager for utils tests * CLN use pytest raises ctxt manager for validation tests * revert test_estimator_check.py to upstream master
…t-learn#16202) * added the link for an open pdf of the article * Address comment Co-authored-by: Roman Yurchak <[email protected]>
…abetes dataset (scikit-learn#16341) * exchanged the boston for diabetes dataset loading * updated the feature names * exchanged remaining feature names * cleaning up * changed features used to age and bmi for easier understanding
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
What does this implement/fix? Explain your changes.
The graph made from grid_to_graph only implements 6 neighbor connectivity. I implemented 18 and 26-connectivity (https://en.wikipedia.org/wiki/Pixel_connectivity#26-connected).
Any other comments?