Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for transparent proxies #8

Open
jjranalli opened this issue May 6, 2023 · 3 comments
Open

Add support for transparent proxies #8

jjranalli opened this issue May 6, 2023 · 3 comments

Comments

@jjranalli
Copy link

jjranalli commented May 6, 2023

Wondering if there's any plan for supporting transparent proxies

Awesome scripts btw 🫡

@0xPhaze
Copy link
Owner

0xPhaze commented May 9, 2023

What doesn't work? I haven't tried it myself, but I imagine it should be quite easy to adapt. Can you adapt the example here to work with transparent proxies?

@jjranalli
Copy link
Author

@0xPhaze sure, I'll be able to do it later this week.

upon further investigation, the issue should come from the fact that in UUPS proxies the upgrade logic is located in the implementation, while in Transparent proxies it lives in the proxy.

so when calling setUpProxy it reverts in assertIsERC1967Upgrade at this line, as the function looks for the proxiableUUID in the implementation

@0xPhaze
Copy link
Owner

0xPhaze commented May 9, 2023

Would a simple override of the function work? I can take a look at it if you get stuck anywhere

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants