Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] astar algorithm pull request #11

Open
orist22 opened this issue Dec 7, 2018 · 4 comments
Open

[BUG] astar algorithm pull request #11

orist22 opened this issue Dec 7, 2018 · 4 comments
Labels
notice Extra attention is needed

Comments

@orist22
Copy link
Contributor

orist22 commented Dec 7, 2018

astar algorithm pull request를 요청했지만 정해진 문법에 맞게 체크하는 bot이 있어 코드상에서 conflict가 나면 accept 되지 못합니다.

기존 코드의 규칙에 맞춰 알고리즘을 구현할 필요가 있습니다.(ex. 함수명 지정 시 camelCase 형태로 지정)
@Minjae77
Copy link
Contributor

Minjae77 commented Dec 7, 2018

확인했습니다.

@orist22
Copy link
Contributor Author

orist22 commented Dec 8, 2018

image
이러한 부분들에서 조심해주세요

@Minki-Kim95
Copy link
Contributor

변수명 지정하는 부분도 조심해야겠군요 알겠습니다

@orist22 orist22 added bug Something isn't working notice Extra attention is needed labels Dec 8, 2018
@yunji-yunji
Copy link
Contributor

기존 코드 규칙에 맞게 코드를 바꿔보도록 하겠습니다.

@orist22 orist22 closed this as completed Dec 9, 2018
@orist22 orist22 removed the bug Something isn't working label Dec 11, 2018
@orist22 orist22 reopened this Dec 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
notice Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@orist22 @Minki-Kim95 @Minjae77 @yunji-yunji