Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[To do] code review 제안합니다. #22

Open
yunji-yunji opened this issue Dec 8, 2018 · 5 comments
Open

[To do] code review 제안합니다. #22

yunji-yunji opened this issue Dec 8, 2018 · 5 comments
Labels
enhancement New feature or request notice Extra attention is needed

Comments

@yunji-yunji
Copy link
Contributor

master repository에 pull request를 보내기 전에
저희 끼리 먼저 pull request를 보내고 댓글 등을 통해 코드 리뷰를 한 후에
실제로 pull request를 날리면 좋을 것 같습니다.

@Minki-Kim95
Copy link
Contributor

좋습니다 브랜치를 따로 파서 작업을 진행하고 pull request를 먼저 날리며 코드리뷰를 하면 더 나은 피드백을 받을 수 있을것 같아요

@Minjae77
Copy link
Contributor

Minjae77 commented Dec 8, 2018

저희끼리 먼저 코드를 테스트 해보는 것도 좋은 생각인 것 같습니다.

@orist22
Copy link
Contributor

orist22 commented Dec 8, 2018

좋은 생각입니다

@orist22 orist22 added enhancement New feature or request notice Extra attention is needed labels Dec 9, 2018
@orist22
Copy link
Contributor

orist22 commented Dec 10, 2018

원래 프로젝트에 다른 사람들이 올린 코드를 리뷰하거나 에러가 난 원인을 파악해주는 것도 의미있을 것 같습니다.

@yunji-yunji
Copy link
Contributor Author

좋은 생각인 것 같습니다!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request notice Extra attention is needed
Projects
None yet
Development

No branches or pull requests

4 participants