Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

load-secrets-action doesn't work on windows #46

Open
Xuanwo opened this issue Jun 25, 2023 · 6 comments
Open

load-secrets-action doesn't work on windows #46

Xuanwo opened this issue Jun 25, 2023 · 6 comments

Comments

@Xuanwo
Copy link

Xuanwo commented Jun 25, 2023

Background

OpenDAL adopts load-secrets-action to manage all secrets. We are trying to load secrets to build our artifacts on linux/macos/windows platform. Java maven will use thoes secrets to sign the packages.

Expected

Secrets loaded as on linux platform.

Actual

Meeting errors like the following:

Run 1password/load-secrets-action@v1
"C:\Program Files\Git\bin\sh.exe" -c D:\a\_actions\1password\load-secrets-action\v1/entrypoint.sh
/usr/bin/bash: line 1: D:a_actions1passwordload-secrets-actionv1/entrypoint.sh: No such file or directory
Error: The process 'C:\Program Files\Git\bin\sh.exe' failed with exit code 127

See action at: https://github.com/apache/incubator-opendal/actions/runs/5367357180/jobs/9737444126?pr=2525

@edif2008
Copy link
Member

edif2008 commented Jul 4, 2023

Hey there.
Currently this GitHub Action is not supported on Windows.

Thank you for sharing that you'd like to see this work on Windows as well. We will keep you updated when there's any progress on this.

@martincostello
Copy link

+1 - it is poor that this wasn’t designed to be cross-platform from the start.

I was interested in adopting this action, but I validate cross-platform compatibility of my code on Linux, macOS and Windows, which makes this action unusable for my purposes as it isn’t a drop-in replacement for native GitHub secrets.

@nikolamilekic
Copy link

+1 Are there any plans to fix this? Thanks!

@itachenko
Copy link

Hey guys, any ETA when this gonna be fixed?

@shyim
Copy link

shyim commented Nov 28, 2023

Maybe an alternative for some https://github.com/shyim/1password-load-secrets-action

@mikeclayton
Copy link

We adopted 1password for enterprise about a year ago and we're gradually integrating it into our GitHub Actions workflows - it's been fine for dotnet / Linux builds but we've started trying to cut over some of our older .Net Framework legacy apps that only build on Windows Runners, and this is now a blocker.

I actually spent a fair bit of time trying to get the action working thinking I was doing something wrong, before I even considered that it might not be supported (see https://1password.community/discussion/comment/712388).

We really only want to have one way of managing secrets and 1Password has been a great fit so far, but it looks like we're going to have to fall back to GitHub Actions Secrets for Windows Runner builds which is going to be miserable...

This seems like such an obvious gap - can we get an update on whether it's even on the roadmap and / or a timescale?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants