Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add end byte to philo id #6

Open
clovis opened this issue Jan 30, 2024 · 0 comments
Open

Add end byte to philo id #6

clovis opened this issue Jan 30, 2024 · 0 comments
Assignees

Comments

@clovis
Copy link
Contributor

clovis commented Jan 30, 2024

This would extend current philo ids to 10 32 bit integers instead of 9. This shouldn't be difficult to implement, but requires many small changes across the Python code base. Too risky for 5.0. Delay to 5.1

Advantages:

  • easier highlighting
  • Tokens stored in the index can be multi-word tokens (e.g named-entities)

Downsides:

  • 4 bytes of extra disk space per token
  • Tiny impact on disk reads (probably not measurable on SSD/NVME drives)
  • Potential for bugs if we miss sections of the code that assume 9 32 bit ints for philo ids.
@clovis clovis added this to the PhiloLogic 5.1 milestone Jan 30, 2024
@clovis clovis self-assigned this Jan 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant