-
Notifications
You must be signed in to change notification settings - Fork 609
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unknown type name 'uintptr_t' #1590
Comments
If
Are you able to test that? Since the /4 makes the number positive it doesn't seem important that kMaxSize needs to be a uintptr_t. |
@reumia, that's curious as it's far from the only use of @peterhillman, could you possibly take a look at this? The code in question declares |
I think @kdt3rd wrote that bit. It certainly looks cleverer than anything I'd write. I would have been tempted to put a constant in there for the maximum file size that will be loaded into memory. I think declaring it as streampos isn't equivalent: a processor could have a 32 bit memory pointer size but still support 64 bit file pointers. |
Thanks for the answers all, this got me into looking a bit closer at the issue and while I don't understand everything yet, I believe this might be partly an issue coming from OpenColorIO, here are some more information:
|
Following up on this, did this get resolved? And @remia, in case it matters, the reason that OpenEXRCore doesn't get the C++ standard flag is that it's written in C, not C++. |
Sorry for the silence @cary-ilm, I think the issue has more to do with the ubuntu-latest runners from Github than OpenEXR. After disabling OpenEXR's tools building, I got a new error this time in OCIO itself which seem to be more related to the STL than OCIO. Quick internet search today yielded this issue GHA, I have to admit I didn't read all the comments in here but it appears to be affecting mostly C++20 builds (which this OCIO bleeding edge workflow uses) and is still not fixed. Feel free to close this ticket! |
Thanks for the follow up. Hopefully actions gets its configuration in order soon. |
We started seeing the following error pop up in OpenColorIO nightly build on ubuntu latest / C++ 20, for example. I believe it might be because uintptr_t is optional to support for C++. I'm not exactly sure what is the maximum size allowed to find a better way to derive, does it depends on the architecture like implied by this code?
The text was updated successfully, but these errors were encountered: