Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

swap router polish #57

Open
shunjizhan opened this issue Jun 18, 2024 · 0 comments
Open

swap router polish #57

shunjizhan opened this issue Jun 18, 2024 · 0 comments

Comments

@shunjizhan
Copy link
Contributor

shunjizhan commented Jun 18, 2024

currently when calculating router address, we only fixed supplyAmount and targetToken. I think we should also fix supplyToken and targetAmount, so that each router address represents a unique swap instruction: "swap X amount of token A to Y amount of token B".

for previous routers we can use the same router address for multiple tokens, since we don't need to consider exchange rate, only recipient.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant