Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lock in specific ledmap upon receiving DDP #3579

Closed
spblat opened this issue Dec 9, 2023 · 3 comments · Fixed by #3554
Closed

Lock in specific ledmap upon receiving DDP #3579

spblat opened this issue Dec 9, 2023 · 3 comments · Fixed by #3554
Labels
enhancement fixed in source This issue is unsolved in the latest release but fixed in master

Comments

@spblat
Copy link

spblat commented Dec 9, 2023

Is your feature request related to a problem? Please describe.

When DDP is received by a WLED from another WLED, the ledmap that is active on the target WLED at that time is the ledmap that applies. If the target has more than one ledmap, we have no way from the sending side to be sure that the LEDs will be mapped correctly during DDP.

Describe the solution you'd like

Establish a specific ledmap that we will adopt when receiving DDP as a client. It should be probably simply be the default ledmap on the target WLED unless you really want another preference in the UI.

Describe alternatives you've considered

If I’m sending DDP to a WLED that usually has a particular ledmap, I could rewrite the ledmap on the sending wled, but relying on nested ledmaps doesn’t make much sense, and the problem remains—depending on the active preset at the time DDP begins we can’t be sure what map will apply.

Or I could switch the target WLED to a preset with the right ledmap before sending DDP. But there’s no way to automate this from the sending side unless we add an API for telling the target WLED to switch to a specific preset (which I would also like).

Additional context

I’m using wled to decorate derelict wall-mounted pinball playfields. The physical ledmap is the best use of finite string. The second ledmap is a logical arrangement of lamps according to their original purpose on the playfield, so that “chase” on a particular segment looks like it did when the game was intact. A third ledmap relates to an effort to make a 2D matrix out of the arrangement of lamps on a playfield. DDP is used to make a matrix out of up to 5 playfields. I’ll post a demo to #showcase in Discord when I’m ready to share. https://github.com/spblat/wled-ncp/tree/main/Playfields

Thank you for working on WLED :-D

@blazoncek
Copy link
Collaborator

Will be solved by #3554

@blazoncek blazoncek linked a pull request Dec 9, 2023 that will close this issue
@blazoncek blazoncek added this to the 0.15.0-alpha candidate milestone Jan 12, 2024
@blazoncek blazoncek added the fixed in source This issue is unsolved in the latest release but fixed in master label Jan 12, 2024
@blazoncek
Copy link
Collaborator

Available in 0.15.0 beta 1.

@spblat
Copy link
Author

spblat commented Mar 31, 2024

Initial test indicates #3554 fix was successful in my setup as of 0.15.0b1. Thank you!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement fixed in source This issue is unsolved in the latest release but fixed in master
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants